Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

No error returned in callback #16

Closed
nodesocket opened this issue Feb 29, 2016 · 2 comments
Closed

No error returned in callback #16

nodesocket opened this issue Feb 29, 2016 · 2 comments

Comments

@nodesocket
Copy link
Contributor

quote_data does not return error in callback.

let symbol = 'AAPL';
rh.quote_data(symbol, function(error, response, body) {
    // error does not seem to be set even though an error occurred
    // for example provided invalid login credentials
}
@nodesocket
Copy link
Contributor Author

Correction, the case of quote_data() does not have an error if you provide invalid login credentials because in-fact you don't need to auth to request this endpoint at all. However it should return error when you pass an invalid ticker symbol such as sfafaffas yet it does not.

@aurbano
Copy link
Owner

aurbano commented Mar 25, 2020

Error reporting will be added in the next major version, currently proposed here #105

@aurbano aurbano closed this as completed Mar 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants