Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Post-launch polishing patch #96

Closed
wants to merge 32 commits into from

Conversation

frederickobrien
Copy link
Member

@frederickobrien frederickobrien commented Nov 19, 2020

Tweaks that weren't important enough to squeeze in for the big move but which can now be added at our leisure. Things I want to do include:

  • Divider line working on homepage
  • Change review image border to outline so artwork is flush with adjacent elements [BUG TO FIX]
  • Flesh out the lead post component on homepage (post authors, summary rather than blurb for reviews, content type, etc)
  • Universal spacing values across the site
  • Remove any 0.5 styling from CSS (problems on Chrome)
  • Adjust navbar so 'About' and 'Contact' appear beneath 'More'
  • Review context notes (if we're having them at all)
  • Remove the big first letter from informational pages

[ADDED ELSEWHERE]

  • Add breadcrumb details to review schema
  • Add images to article structured data
  • Container class for album artwork in articles so they too can have a grey outline
  • Embedded media container class for articles, so iframes/videos/etc adjust with minimum faff
  • Add 'and' before last author on reviews
  • Artwork credit functionality on review pages

This was linked to issues Nov 19, 2020
@andrewbridge
Copy link
Member

Adjust navbar so 'About' and 'Contact' appear beneath 'More'

A word of warning, this may be more involved than it sounds!

@frederickobrien
Copy link
Member Author

Closing this, remaining issues will be addressed one by one.

@frederickobrien frederickobrien deleted the post-launch-polishing-patch branch April 18, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review context notes Award design Artwork information
2 participants