From 927f8f9213450e7223c94cd10cb25a494b4e696a Mon Sep 17 00:00:00 2001 From: Jake Coble Date: Tue, 8 Oct 2024 13:50:02 -0400 Subject: [PATCH 1/4] Add hasIncompletePlaybackSession to Continue Listening query --- .../organisms/cardSlider/section/continueListening.graphql | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/organisms/cardSlider/section/continueListening.graphql b/src/components/organisms/cardSlider/section/continueListening.graphql index 094770a70..d21437952 100644 --- a/src/components/organisms/cardSlider/section/continueListening.graphql +++ b/src/components/organisms/cardSlider/section/continueListening.graphql @@ -9,6 +9,7 @@ query getSectionContinueListening( language: $language first: $first after: $after + hasIncompletePlaybackSession: true ) { nodes { recording { From bd0fc74bd75ca6b06f25be38e21b60ea5c9160d8 Mon Sep 17 00:00:00 2001 From: Jake Coble Date: Tue, 8 Oct 2024 15:31:08 -0400 Subject: [PATCH 2/4] Fix audit failure --- audit-ci.json | 5 ++++- package-lock.json | 17 +++++++++++++---- package.json | 2 +- 3 files changed, 18 insertions(+), 6 deletions(-) diff --git a/audit-ci.json b/audit-ci.json index 19c5ddd34..416df33f9 100644 --- a/audit-ci.json +++ b/audit-ci.json @@ -27,6 +27,9 @@ "GHSA-m6fv-jmcg-4jfg", // Used by lighthouse CI, not at runtime "GHSA-m6fv-jmcg-4jfg", // Used by lighthouse CI, not at runtime "GHSA-cm22-4g7w-348p", // Used by lighthouse CI, not at runtime - "GHSA-gp8f-8m3g-qvj9" // Deployments on Vercel are not affected + "GHSA-gp8f-8m3g-qvj9", // Deployments on Vercel are not affected + "GHSA-pxg6-pf52-xh8x|@lhci/cli>*", // Used by lighthouse CI, not at runtime + "GHSA-pxg6-pf52-xh8x|@lhci/utils>*", // Used by lighthouse CI, not at runtime + "GHSA-pxg6-pf52-xh8x|express>cookie" // Used by lighthouse CI, not at runtime ] } diff --git a/package-lock.json b/package-lock.json index 6a835419b..6fdafc484 100644 --- a/package-lock.json +++ b/package-lock.json @@ -15,7 +15,7 @@ "@tanstack/react-query": "^4.29.12", "@tanstack/react-query-devtools": "^4.33.0", "clsx": "^1.2.1", - "cookie": "^0.4.1", + "cookie": "^0.7.0", "dayjs": "^1.10.7", "feed": "git+https://mattleff@github.com/mattleff/feed.git#custome-elements-build", "full-icu": "^1.5.0", @@ -7768,6 +7768,15 @@ "node": ">= 6.0.0" } }, + "node_modules/@sentry/node/node_modules/cookie": { + "version": "0.4.2", + "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.4.2.tgz", + "integrity": "sha512-aSWTXFzaKWkvHO1Ny/s+ePFpvKsPnjc551iI41v3ny/ow6tBG5Vd+FuqGNhh1LxOmVzOlGUriIlOaokOvhaStA==", + "dev": true, + "engines": { + "node": ">= 0.6" + } + }, "node_modules/@sentry/node/node_modules/https-proxy-agent": { "version": "5.0.1", "resolved": "https://registry.npmjs.org/https-proxy-agent/-/https-proxy-agent-5.0.1.tgz", @@ -15879,9 +15888,9 @@ "integrity": "sha512-Kvp459HrV2FEJ1CAsi1Ku+MY3kasH19TFykTz2xWmMeq6bk2NU3XXvfJ+Q61m0xktWwt+1HSYf3JZsTms3aRJg==" }, "node_modules/cookie": { - "version": "0.4.2", - "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.4.2.tgz", - "integrity": "sha512-aSWTXFzaKWkvHO1Ny/s+ePFpvKsPnjc551iI41v3ny/ow6tBG5Vd+FuqGNhh1LxOmVzOlGUriIlOaokOvhaStA==", + "version": "0.7.0", + "resolved": "https://registry.npmjs.org/cookie/-/cookie-0.7.0.tgz", + "integrity": "sha512-qCf+V4dtlNhSRXGAZatc1TasyFO6GjohcOul807YOb5ik3+kQSnb4d7iajeCL8QHaJ4uZEjCgiCJerKXwdRVlQ==", "engines": { "node": ">= 0.6" } diff --git a/package.json b/package.json index 1e948fe4e..02bf71060 100644 --- a/package.json +++ b/package.json @@ -41,7 +41,7 @@ "@tanstack/react-query": "^4.29.12", "@tanstack/react-query-devtools": "^4.33.0", "clsx": "^1.2.1", - "cookie": "^0.4.1", + "cookie": "^0.7.0", "dayjs": "^1.10.7", "feed": "git+https://mattleff@github.com/mattleff/feed.git#custome-elements-build", "full-icu": "^1.5.0", From a69a101caab5783f73094b08f78e703485dd6ee0 Mon Sep 17 00:00:00 2001 From: Jake Coble Date: Thu, 10 Oct 2024 09:42:48 -0400 Subject: [PATCH 3/4] Use pa11y's axe runner to avoid scanning empty iframes --- pa11y-ci.json | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pa11y-ci.json b/pa11y-ci.json index 0455f7085..6464936b3 100644 --- a/pa11y-ci.json +++ b/pa11y-ci.json @@ -1,3 +1,5 @@ { + // WORKAROUND: https://github.com/pa11y/pa11y/issues/652 + "runner": "axe", "hideElements": "iframe[src*=\"doubleclick.net\"]" } From f15708c1d0ac2eb45f8430c34bc132f32ff3da5c Mon Sep 17 00:00:00 2001 From: Jake Coble Date: Thu, 10 Oct 2024 09:52:39 -0400 Subject: [PATCH 4/4] Fix incorrect JSON syntax --- pa11y-ci.json | 1 - 1 file changed, 1 deletion(-) diff --git a/pa11y-ci.json b/pa11y-ci.json index 6464936b3..d55d9aeb1 100644 --- a/pa11y-ci.json +++ b/pa11y-ci.json @@ -1,5 +1,4 @@ { - // WORKAROUND: https://github.com/pa11y/pa11y/issues/652 "runner": "axe", "hideElements": "iframe[src*=\"doubleclick.net\"]" }