Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library scanning doesn't recognize .adx files even though they are supported #1466

Closed
BlipBlerp opened this issue Sep 9, 2024 · 5 comments
Closed
Labels
Bug Something isn't working
Milestone

Comments

@BlipBlerp
Copy link

Describe the bug
If I scan my music folder, files with the .adx extension won't be added to my library

Steps to reproduce
How and when does the bug occur?
It occurs when I try to scan a folder with an .adx file. If .adx is the only extension in a directory, a message will popup saying "No files were found in the directory". If I try to open the file it plays just as expected

Expected behavior
What do you expect to happen instead?
The .adx are recognized and added to my library

Additional information

  • Audacious version and interface (Qt / GTK / Winamp)
    4.4, Qt
  • Operating system and version
    Nobara Linux 40
  • Desktop environment
    KDE
  • Screenshots
  • Sample files
    (probably can't for legal reasons)
  • Logs (use LANG=C audacious -V for English output)
@BlipBlerp BlipBlerp added the Bug Something isn't working label Sep 9, 2024
@mschwendt
Copy link

It may be that one of the input plugins' backend libraries recognizes ADX files, but none of the plugins declares that it handles files with ".adx" extension. Hence those files are not officially "supported".

Just in case, do you have the "Probe content of files with no recognized file name extension" checkbox marked in the advanced settings? Which plugin is it that recognizes those files when you add them?

@BlipBlerp
Copy link
Author

Oh I wasn't aware of that option. Yeah enabling it works, but it will also scan my covers as songs, which is not ideal.

Regarding plugin, I am not quite sure.
image
Looking at that list (default plugins that came with the audacious flatpak) I guess it must be the game console music decoder, since adx was a format used in games

@mschwendt
Copy link

Possibly ffmpeg, since ADX is an ADPCM derivative.
Running "audacious -V yourfile.adx" would give a clue.

Activating the file detection is only a workaround. Mission objective would be to figure out which input plugin supports ADX files and then to add the ".adx" extension to the plugin's list of supported file types.

@BlipBlerp
Copy link
Author

Possibly ffmpeg, since ADX is an ADPCM derivative.

You were right! I ran the command as you said (only that instead of audacious I had to flatpak run) and reading through the logs it appears to cycle through the plugins until it gets to the ffmpeg/ffaudio plugin and then finds a match as such:

INFO ../src/libaudcore/plugin-load.cc:64 [plugin_load]: Loading plugin: /app/lib/audacious/Input/ffaudio.so.
INFO ../src/ffaudio/ffaudio-core.cc:282 [get_format_by_extension]: Matched format adx by extension.
INFO ../src/libaudcore/probe.cc:171 [aud_file_find_decoder]: Matched FFmpeg Plugin by content.
INFO ../src/ffaudio/ffaudio-core.cc:282 [get_format_by_extension]: Matched format adx by extension.

@radioactiveman
Copy link
Member

Mission objective would be to figure out which input plugin supports ADX files and then to add the ".adx" extension to the plugin's list of supported file types.

Done with audacious-media-player/audacious-plugins@ebcad66. Thanks for the investigation Michael.

@radioactiveman radioactiveman added this to the 4.4.1 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants