[Bug]: breaking API change with tiny_bip39 v1.0.1

[aaronmrice]

What did you expect to happen?

I am attempting to build from source on both Ubuntu and macOS. I expect that git tags correspond to error-free source code (I had v18.3.0 checked out).

What happened?

I run into the following compiler error:

error[E0532]: expected unit struct, unit variant or constant, found tuple variant `bip39::ErrorKind::InvalidWord`
  --> crates/atuin-client/src/login.rs:29:21
   |
29 |                     bip39::ErrorKind::InvalidWord => key,
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the tuple variant pattern syntax instead: `bip39::ErrorKind::InvalidWord(_)`
   |
  ::: /Users/aaron/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tiny-bip39-1.0.1/src/error.rs:9:5
   |
9  |     InvalidWord(usize),
   |     ----------- `bip39::ErrorKind::InvalidWord` defined here

The atuin and atuin-client crates depend upon tiny-bip39 = "1". However, tiny_bip39 released a v1.0.1 with a breaking change in this InvalidWord variant. I don't know whether it's better to specify tiny-bip39 = "=1.0.0" or try to get tiny_bip39 to change it's v1.0.1 package.

Atuin doctor output

N/A

Code of Conduct

• I agree to follow this project's Code of Conduct

[aaronmrice]

Related issue filed on tiny_bip39: maciejhirsz/tiny-bip39#52

[juliancarrivick]

For anyone looking for a workaround for building from source, you can install using cargo install atuin --locked

[ellie]

I've just updated Cargo.toml to work around this one. Once upstream has resolved it, I'll revert my PR