Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce a new 'register' package with consolidated code #508

Draft
wants to merge 19 commits into
base: trunk
Choose a base branch
from
Draft

feat: introduce a new 'register' package with consolidated code #508

wants to merge 19 commits into from

Conversation

srieteja
Copy link
Contributor

@srieteja srieteja commented Jan 29, 2024 •
edited
Loading

Closes #468

- What I did

  • Consolidated code from Register_cli and onboarding_flutter, pertaining to fetching free atsigns and getting them registered to an email.
  • This new consolidated code has been written into a package which is now called AtRegister.
  • Consume AtRegister in register_cli and make necessary changes to allow this consumption

- How I did it

- How to verify it

  • Unit tests present in at_register package
  • Unit tests present in onboarding_cli to validate register_cli which now consumes AtRegister

- Description for the changelog

feat: introduce a new 'AtRegister' package with consolidated code reg registration of free atsigns

@srieteja srieteja marked this pull request as draft January 29, 2024 22:11
@srieteja srieteja mentioned this pull request Mar 4, 2024
Open
9 tasks
@srieteja srieteja mentioned this pull request Mar 6, 2024
Open
@srieteja srieteja self-assigned this Mar 6, 2024
@srieteja srieteja marked this pull request as ready for review March 6, 2024 23:12
@srieteja srieteja requested a review from VJag March 6, 2024 23:12
@gkc
Copy link
Contributor

gkc commented Oct 8, 2024

@srieteja @sitaram-kalluri This PR is very old. Should we close it, and re-prioritize #468 ? There was a lot of work here, it's not clear to me why it was abandoned

@srieteja
Copy link
Contributor Author

srieteja commented Oct 8, 2024

@gkc, this is a part of #468. We decided to take focus off apps for some time and this one fell through the cracks. The work here is still relevant to upgrade onboarding_cli from using the registrar v2 API to v3 API. I can put some time into it next week and bring this up to speed if we believe this is a priority.

@gkc
Copy link
Contributor

gkc commented Oct 8, 2024

@srieteja You should stay focused on the C impl of at_activate. Please mark this as draft and add a comment to the associated ticket.

@srieteja
Copy link
Contributor Author

srieteja commented Oct 8, 2024

@srieteja You should stay focused on the C impl of at_activate. Please mark this as draft and add a comment to the associated ticket.

Sure @gkc

@srieteja srieteja marked this pull request as draft October 8, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murali-shris murali-shris Awaiting requested review from murali-shris

@sitaram-kalluri sitaram-kalluri Awaiting requested review from sitaram-kalluri

@VJag VJag Awaiting requested review from VJag

At least 1 approving review is required to merge this pull request.

Assignees

@srieteja srieteja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate shared code of onboarding flutter and onboarding cli to a new package.
3 participants
@srieteja @gkc @VJag