Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation #5

Open
N0wan opened this issue Jun 3, 2020 · 12 comments
Open

French translation #5

N0wan opened this issue Jun 3, 2020 · 12 comments

Comments

@N0wan
Copy link
Contributor

N0wan commented Jun 3, 2020

Hey there !

Would you be interested by a translation in French language ?

@N0wan
Copy link
Contributor Author

N0wan commented Jun 4, 2020

I can easily translate all the strings.
But would you provide a multi-language app (needing the code to be adapted) ?
The other solution being to provide one app per language (less good).

@atorch
Copy link
Owner

atorch commented Jun 4, 2020

That would be wonderful! I need to read up on how to make a single app with multiple languages, but that sounds by far like the better option (relative to multiple single-language apps).

@N0wan
Copy link
Contributor Author

N0wan commented Jun 5, 2020

Yes indeed.
So, when you'll modify the source code, or add new features, you'll only have to do it once.
Actually that will be my first contribution to a multi-language app... sounds interesting !
Btw, I'm a fan of your app !

@rillig
Copy link
Contributor

rillig commented Jan 29, 2022

See #7, where I am adding the German translation. The main part is really only adding a file values-de/strings.xml containing the translated strings.

Some of the images need to be translated as well as they contain text. I left that for later, but I still have the list for translating the images in my e-mail archive.

@N0wan
Copy link
Contributor Author

N0wan commented Feb 4, 2022

For sure, I can do that.
But just to be sure, why can't I find your folder values-de in any branch ?

@rillig
Copy link
Contributor

rillig commented Feb 4, 2022

The German translation is in my fork over at https://github.com/rillig/probability_puzzles, in the master branch.
Before starting to translate, you might ask @atorch whether he still wants to release a new version of the app including the translations, just to make sure you don't waste time doing the translation for nothing.

@N0wan
Copy link
Contributor Author

N0wan commented Feb 8, 2022

Thanks, I'll do so

@N0wan
Copy link
Contributor Author

N0wan commented Feb 8, 2022

Actually, I don't know how to contact him... ?

@atorch
Copy link
Owner

atorch commented Feb 9, 2022

Hey, I'm here! I see #7, I'll give it a try on my phone when I have some free time

@atorch
Copy link
Owner

atorch commented Feb 9, 2022

@ghost
Copy link

ghost commented Aug 11, 2022

Hello, I could do Greek and Spanish translations.

@atorch
Copy link
Owner

atorch commented Aug 11, 2022

@esodigoyo that would be great, thank you for offering! Have a look at #20 (comment) and https://github.com/atorch/probability_puzzles/blob/master/app/src/main/res/values-de/strings.xml and https://developer.android.com/guide/topics/resources/localization#creating-alternatives to see how translations work. Let me know if you need additional tips! This issue is about a French translation specifically, so let's open a separate issue for Greek and Spanish in the event that you have any questions specific to creating a values.xml file for those languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants