From ce28df4cdc955782ee471b1ba39eb8cfed42aa8d Mon Sep 17 00:00:00 2001 From: Ruslan Sadykov <41117501+rrsadykov@users.noreply.github.com> Date: Wed, 31 Jan 2024 13:55:21 +0100 Subject: [PATCH] Correction to support Julia 1.10 and putting back the tests with the latest Julia version (#1125) --- .github/workflows/ci.yml | 6 ++---- src/MathProg/vcids.jl | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0ccd7368c..0d9381537 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,10 +14,8 @@ jobs: fail-fast: false matrix: version: - - '1.6.7' # minimum Julia version that your package supports. (new LTS) - - '1.8.5' # "work" version for Atoptima deployements - #- '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia. - # for the moment, latest stable version 1.10 errors, we need to repair it + - '1.6' # minimum Julia version that your package supports. (new LTS) + - '1' # Leave this line unchanged. '1' will automatically expand to the latest stable 1.x release of Julia. os: - ubuntu-latest arch: diff --git a/src/MathProg/vcids.jl b/src/MathProg/vcids.jl index ac65fa5b0..23ee66193 100644 --- a/src/MathProg/vcids.jl +++ b/src/MathProg/vcids.jl @@ -73,7 +73,7 @@ Base.promote_rule(::Type{<:Id}, ::Type{<:Id}) = Int # existing ids. # As we want that all operations on ids results on operations on the uid, # we redefine the promotion mechanism for Ids so that operations on Ids return integer: -Base.promote_type(::Type{I}, ::Type{I}) where {I<:Id} = Int32 +Base.promote_type(::Type{I}, ::Type{I}) where {I<:Id} = Int Base.convert(::Type{Int}, id::I) where {I<:Id} = Int(id.uid) Base.convert(::Type{Int32}, id::I) where {I<:Id} = id.uid