Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default terminal magenta color #57

Open
Arnesfield opened this issue Nov 25, 2024 · 0 comments
Open

Change the default terminal magenta color #57

Arnesfield opened this issue Nov 25, 2024 · 0 comments

Comments

@Arnesfield
Copy link

I've switched to this theme recently having used Material Theme for years and I am absolutely loving it!

One thing that kept bugging me however, is the default terminal magenta color.

For comparison, I've posted screenshots below of a few color themes:

  1. Default Dark+

    theme-default-dark+

  2. Default High Contrast

    theme-default-high-contrast

  3. Material Theme Palenight High Contrast

    theme-material-theme-palenight-high-contrast

  4. Monokai Dimmed

    theme-monokai-dimmed

  5. Moonlight

    theme-moonlight-ii-custom

The Moonlight theme above uses a custom terminal magenta color. Currently, the default is #fca7ea, but I checked the theme's colors and opted to use #c4a2ff instead.

I've customized the theme in VS Code settings like so:

"workbench.colorCustomizations": {
  "[Moonlight II]": {
    // ...
    "terminal.ansiBrightMagenta": "#c4a2ff",
    "terminal.ansiMagenta": "#c4a2ff"
  }
}

Using the default terminal magenta color, it would look like this:

theme-moonlight-ii

Personally, the first time I saw it, it felt a little off as it leans more on the pinkish side than purplish.

My suggestion is to change the default terminal magenta colors (terminal.ansiBrightMagenta and terminal.ansiMagenta) from #fca7ea to #c4a2ff.

I know this change is very much subjective, and I'm fine with it if the color choice was intentional and that there are will be no plans to change it. It can be changed via color customizations so it isn't a big issue. But I just had to mention it, and that maybe #c4a2ff might look a bit more magenta.

Thanks for the amazing theme! I don't think I'll be switching themes for years to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant