Order Submission Issue

[dumbo321]

I tried to make 5 KMD/RICK orders very quickly. I did not wait till the orders showed up on the GUI to place the next one. It looks like all 5 is open but on the KMD sell order side, I can see the same line on the KMD sell order side flicking between all the various prices i put up (50/52/53/54) Why are these not their own lines?

Is there a timer value here in terms of how fast new orders can be placed? Should there be a please wait for order to be processed etc?

[lukechilds]

@dumbo321 thanks for the detailed report, I was able to re-create this.

Normally when you place an order you are a taker and you won't appear in the order book. However if your order is not filled after a certain amount of time, marketmaker will re-create your order as a maker, and in that case your order will now show in the order book.

Because you are creating an order on a pair with no activity, your orders aren't getting filled, so they are all getting converted to maker orders, which should show in the order book.

I created 5 orders on the CHIPS/RICK pair of prices 0.1, 0.2, 0.3, 0.4, 0.5. They all went to maker orders but I only saw one entry in the order book that constantly shuffled between those 5 prices, as you described.

I can confirm this is definitely a marketmaker issue and not an issue in the GUI. For some reason it is only returning one of the order prices each time we request the order book. Maybe it's using the address/pubkey as a unique ID for orders?

You can see the buggy behaviour isolated to marketmaker here by just requesting the order book with cURL:

$ curl 'http://127.0.0.1:56497/' -H 'Referer: http://localhost:8080/dev.html' -H 'Origin: http://localhost:8080' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) HyperDEX/0.4.0 Chrome/73.0.3683.121 Electron/5.0.2 Safari/537.36' -H 'Content-Type: text/plain;charset=UTF-8' --data-binary '{"method":"orderbook","base":"CHIPS","rel":"RICK","userpass":"<redacted>"}' --compressed
{"askdepth":0,"asks":[],"base":"CHIPS","biddepth":0,"bids":[{"coin":"RICK","address":"RQm8BNygniNVqVPRYXEosznRZ7uEiooqSm","price":0.01,"numutxos":0,"avevolume":0.0,"maxvolume":0.01,"depth":0.0,"pubkey":"30b4191bd253364abe8c19976f196bbcc2f3e66724816ef70e7fe472b5f59d0c","age":0,"zcredits":0}],"netid":0,"numasks":0,"numbids":1,"rel":"RICK","timestamp":1564675907}%
hyperdex %
$ curl 'http://127.0.0.1:56497/' -H 'Referer: http://localhost:8080/dev.html' -H 'Origin: http://localhost:8080' -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) HyperDEX/0.4.0 Chrome/73.0.3683.121 Electron/5.0.2 Safari/537.36' -H 'Content-Type: text/plain;charset=UTF-8' --data-binary '{"method":"orderbook","base":"CHIPS","rel":"RICK","userpass":"<redacted>"}' --compressed
{"askdepth":0,"asks":[],"base":"CHIPS","biddepth":0,"bids":[{"coin":"RICK","address":"RQm8BNygniNVqVPRYXEosznRZ7uEiooqSm","price":0.05,"numutxos":0,"avevolume":0.0,"maxvolume":0.05,"depth":0.0,"pubkey":"30b4191bd253364abe8c19976f196bbcc2f3e66724816ef70e7fe472b5f59d0c","age":1,"zcredits":0}],"netid":0,"numasks":0,"numbids":1,"rel":"RICK","timestamp":1564675910}%

The first cURL response returns the price as 0.01. The second identical order book request returns the price as 0.05. We are displaying the data in the GUI exactly as we get it from marketmaker.

@artemii235 are you aware of this issue?

[artemii235]

@lukechilds The corresponding MM2 issue is closed, the bug should be fixed in the KomodoPlatform/komodo-defi-framework@d30c429. Please update MM2 in HyperDEX bundle and retest.