Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larger swap message #404

Closed
jdmarlow86 opened this issue Jul 4, 2018 · 2 comments
Closed

Larger swap message #404

jdmarlow86 opened this issue Jul 4, 2018 · 2 comments
Labels
marketmaker v2 Not feasible until version 2 of marketmaker

Comments

@jdmarlow86
Copy link

When I try to do a BEER/PIZZA swap with a larger than usual amount I get the below message. The first part of the message makes sense about the deposit size but the second instruction wouldn't work if I just deposited more and tried a larger swap.

Version: alpha 8
OS: win 10
Errors: below
Severity: Low (3)

image

@lukechilds
Copy link
Member

Thanks for reporting, we're aware the errors in HyperDEX often aren't that helpful. This is because almost all the errors come direct from marketmaker, not from HyperDEX.

The way error reporting works in marketmaker is very limited and doesn't give us a lot of options to handle them better.

We've reported the issue upstream but doesn't look like it will be fixed soon. We probably won't be able to implement better messages in HyperDEX until we get better error reporting in marketmaker v2.

Relevant issues:
jl777/SuperNET#717
jl777/SuperNET#594

@sindresorhus sindresorhus added marketmaker v2 Not feasible until version 2 of marketmaker and removed marketmaker related labels Jul 13, 2018
@sindresorhus
Copy link
Contributor

Closing this in favor of #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketmaker v2 Not feasible until version 2 of marketmaker
Projects
None yet
Development

No branches or pull requests

3 participants