File name appendage on Mercurial (TortoiseHg) change

[Anthropic]

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Possibly related to #306 based on comments there, when changing branch or reverting a change from Mercurial the files get renamed in the tab, disconnecting them from the filesystem and recognition of file type. This does not occur with another

The annoying part is that even using save-as it doesn't open the same folder where the file was so it takes a while to line them back up again if there are any unsaved changes. I had this happen with over 20 open files and couldn't save any changes.

I am not sure if this is a regression as suggested in #306 or just a bug only partially related.

Steps to Reproduce

1. Open a file in Atom (from a Mercurial repository)
2. Make a change in the file and save
3. Change the file from TortoiseHG Workbench either by
   a. reverting the change
   b. changing the branch to another with the same file

Expected behavior:
The file name in the tab should remain the same like other IDEs.

Actual behavior:
The file name changes with a random appendage of characters, the file type is irrelevant:

Reproduces how often: [What percentage of the time does it reproduce?]
100% Every time, even in safe mode.

Versions

Atom : 1.15.0-beta1
Electron: 1.3.13
Chrome : 52.0.2743.82
Node : 6.5.0

apm 1.15.3
npm 3.10.5
node 4.4.5 ia32
python 2.7.2
git 1.7.11.msysgit.1
visual studio 2012

Windows 7 Pro sp 1

@iolsen @ungb

[ungb]

Hey @Anthropic, I was able to repro this on windows.

Repro steps(on windows):

1. Install http://bitbucket.org/tortoisehg/files/downloads/tortoisehg-4.1.1-x64.msi
2. run hg clone https://selenic.com/repo/bloatwatch
3. Open Atom and make sure closed deleted files is unchecked
   
4. Open the project which you cloned in step 2.
5. Make some changes to bloatweb.py and save
6. Open the project in windows explorer and revert the file.
   
7. After reverting, notice on Atom the file is renamed, but it isn't associated to any file or saved.
   

This looks like a legit issue as I tested it on Sublime Text and saw it works fine. @iolsen This is probably related to changes in pr atom/atom#13978 since if I uncheck that box, the tabs will close on revert.

The issue you're seeing with save as opening in a different directory is issue atom/atom#13978.

[ungb]

I'm going to remove the regression tag since this is more of a new bug due to new functionality. @50Wliu

[Anthropic]

@ungb when you say related to changes in pr atom/atom#13978 I'm not so sure, my first comment on #306 was Jul 20 2016, it had been happening for many months prior to that also, I just kept checking back every now and then, so it has been happening for a long time.

Thanks so much for reproducing, I appreciate your time and effort :)

[Anthropic]

@ungb any chance this will get triaged at some point soon?

[ungb]

hey @Anthropic, this has been triaged and currently in our backlog.

[Anthropic]

@ungb thanks for the update, I forgot about this and got stung by it again, my own fault obviously, but would be nice not to have to worry about it. Cheers :)