Constant with name 'NO' is incorrectly (?) marked as language constant.

Hello

It appears that class constants are usually marked with the .constant.other property, but a constant with the name 'NO' (as in "yes" and "no") is marked as .constant.language:

class Foo
{
    const MAYBE; // Marked as .constant.other
    const YES; // Marked as .constant.language
    const NO; // Marked as .constant.language
}

PHP also doesn't seem to complain about usage of these names. Built-in constants such as PHP_EOL experience the same problem (although I wouldn't go redefining these inside classes to avoid confusion). I'm also not entirely sure why YES and NO are marked as language constants, as I can't seem to find them in the documentation nor using get_defined_constants. (perhaps I've just never heard of them?)

Thanks in advance

[Ingramz]

It's true that constants such as YES and NO have not been defined in PHP by default.

PHP grammar in use here is based on TextMate's PHP grammar. Going back in time we can see that these constants were first introduced into the grammar in 2005 with a helpful comment.

https://github.com/textmate/php.tmbundle/blob/a4a5b4143aa8bee0f6c92f5d89a78183c9639328/Syntaxes/PHP.plist#L1003-L1008

Common and some good usability shortcuts (need to be define()'d )

This tells us that these were intentionally added as a way to provide specific highlighting for commonly appearing constants, even if they were not defined by default. While the highlighting part might not be true anymore today, especially in Atom, nobody has really considered them harmful, so it has remained the same since. They could be removed if desired (pull requests are welcome).