Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Offer custom property tokens to autocomplete #103

Closed
WoodyWoodsta opened this issue Jan 30, 2017 · 3 comments · May be fixed by #102
Closed

Offer custom property tokens to autocomplete #103

WoodyWoodsta opened this issue Jan 30, 2017 · 3 comments · May be fixed by #102

Comments

@WoodyWoodsta
Copy link

WoodyWoodsta commented Jan 30, 2017

Expected behavior: Custom properties (--custom-property-123) should be offered for the autocomplete-plus Symbol Provider

Actual behavior: Custom properties are not listed by autocomplete

Versions

Atom 1.15.0

@winstliu
Copy link
Contributor

winstliu commented Jan 30, 2017

I can't reproduce using [email protected]. Here's an example I took from MDN.
image
The variable in :root is tokenized as variable.css while the one in background-color is variable.argument.css.

@Alhadis
Copy link
Contributor

Alhadis commented Jan 30, 2017

Actual behavior: Custom properties are not tokenized

@WoodyWoodsta In what sense did you mean "tokenised"? That word has special meaning with relation to language grammars, and is chiefly related to syntax highlighting. Did you mean to say "custom properties are not listed by autocomplete"?

If not, I fail to see how highlighting is connected with autocomplete suggestions.

@WoodyWoodsta
Copy link
Author

@Alhadis You're correct. The variables are tokenised correctly. They were not, however, showing up in autocomplete. I have corrected the original post.

@50Wliu I stand to be corrected, but the use of --main-bg-color in the CSS var function falls under the variable.argument.css scope, but also under the meta.function.variable.css, which should be caught by the .variable.css selector?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants