strlen crash

[kevinsawicki]

Saw this crash while pairing with @8-uh, seemed to occur at startup.

Didn't happen consistently, I don't think any non-standard keyboard layout was being used.

Doing a bit of googling seems to suggest that the kTISPropertyInputSourceID may return NULL.

Process:               Atom Helper [91256]
Path:                  /Applications/Atom.app/Contents/Frameworks/Atom Helper.app/Contents/MacOS/Atom Helper
Identifier:            com.github.atom.helper
Version:               1.15.0 (1.15.0)
Code Type:             X86-64 (Native)
Parent Process:        Atom [91201]
Responsible:           Atom [91201]
User ID:               501
Date/Time:             2017-04-06 13:20:20.631 -0500
OS Version:            Mac OS X 10.12.3 (16D32)
Report Version:        12
Anonymous UUID:        9DB2C149-B0C2-EAC7-F4DD-3D029E5B71AB
Sleep/Wake UUID:       645CF1A8-67BE-492D-8867-62BCF5C1C314
Time Awake Since Boot: 59000 seconds
Time Since Wake:       3300 seconds
System Integrity Protection: disabled
Crashed Thread:        0  CrRendererMain  Dispatch queue: com.apple.main-thread
Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000000
VM Regions Near 0:
--> 
    __TEXT                 0000000104e34000-0000000104e35000 [    4K] r-x/rwx SM=COW  /Applications/Atom.app/Contents/Frameworks/Atom Helper.app/Contents/MacOS/Atom Helper
Thread 0 Crashed:: CrRendererMain  Dispatch queue: com.apple.main-thread
0   libsystem_c.dylib               0x00007fffbc0d1b52 strlen + 18
1   libnode.dylib                   0x0000000108f2785c v8::String::NewFromUtf8(v8::Isolate*, char const*, v8::NewStringType, int) + 156
2   keyboard-layout-manager.node    0x000000010e425462 KeyboardLayoutManager::GetCurrentKeyboardLayout(Nan::FunctionCallbackInfo<v8::Value> const&) + 102
3   keyboard-layout-manager.node    0x000000010e425f8b Nan::imp::FunctionCallbackWrapper(v8::FunctionCallbackInfo<v8::Value> const&) + 141
4   libnode.dylib                   0x0000000108f3e09a v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) + 298
5   libnode.dylib                   0x0000000108f77ae5 0x108b94000 + 4078309
6   libnode.dylib                   0x0000000108f7994e 0x108b94000 + 4086094
7   ???                             0x000034d516a08ba7 0 + 58089812298663
8   ???                             0x000034d517e431bb 0 + 58089833509307
9   ???                             0x000034d517e427a2 0 + 58089833506722
10  ???                             0x000034d517e41939 0 + 58089833503033
11  ???                             0x000034d517e3fd8c 0 + 58089833495948
12  ???                             0x000034d516a08db5 0 + 58089812299189
13  ???                             0x000034d517e3fa8d 0 + 58089833495181
14  ???                             0x000034d517e3f949 0 + 58089833494857
15  ???                             0x000034d516a08db5 0 + 58089812299189
16  ???                             0x000034d516a45fa3 0 + 58089812549539
17  ???                             0x000034d516a29f0f 0 + 58089812434703
18  libnode.dylib                   0x0000000109251b5b 0x108b94000 + 7068507
19  libnode.dylib                   0x000000010925195b v8::internal::Execution::Call(v8::internal::Isolate*, v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*) + 331
20  libnode.dylib                   0x0000000108f24a77 v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*) + 535