Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DataArray #97

Open
lkluft opened this issue Oct 2, 2019 · 0 comments
Open

Introduce DataArray #97

lkluft opened this issue Oct 2, 2019 · 0 comments
Labels
discussion enhancement New feature or request

Comments

@lkluft
Copy link
Member

lkluft commented Oct 2, 2019

While restructuring the cloud class I realised how messy a lot of the component/core implementation is. Even though I still think that omitting xr.Dataset was a good idea, we could/should have sticked to the idea of a data array.

This change would move additional information (e.g. dimensions, units, ...) from the Component class to a derived array class. This derived class could be an xr.DataArray or even simpler (I don't think we need more than two or three additional attributes). The Component class would be way simpler as it only needs a dictionary to store and access the different data arrays.

This issue serves as a place to discuss this idea.

Disclaimer: I am not sure how much of the code we would need to touch for this to work. That's why I want to discuss, if we think it is worth the effort beforehand.

@lkluft lkluft added enhancement New feature or request discussion labels Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant