Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Move out of iframe to embed visualization? #40

Closed
clemsos opened this issue Mar 12, 2019 · 3 comments
Closed

Move out of iframe to embed visualization? #40

clemsos opened this issue Mar 12, 2019 · 3 comments
Labels
question Further information is requested

Comments

@clemsos
Copy link
Member

clemsos commented Mar 12, 2019

Currently we are using an iframe

https://github.com/theatlasofdata/theatlasofdata.earth/blob/c8e01d13f66240c4b46f9f7af93e4554e11661e4/_layouts/post.html#L20

Will it be better to directly embed the svg?

@MAKIO135 ideas?

@clemsos clemsos added the question Further information is requested label Mar 12, 2019
@MAKIO135
Copy link

MAKIO135 commented Mar 12, 2019

Will it be better to directly embed the svg?

Don't think so: it would need to generate the svg first, meaning loading the the viz & rendering it in a separate context to avoid dependencies version problems, and that would make the viz less interactive (no more JS events)

@clemsos
Copy link
Member Author

clemsos commented Mar 13, 2019

True. I was asking because we have very few control about how things shows up in an iframe VS an embed viz in the page.

Maybe we need a viz.html template where we have a bunch of defined variables (like width, height, etc) so we can have proper support for mobile (#39) as well as coherent color schemes and VI across the different viz (see atlasofdata/visual-identity#2).

@clemsos
Copy link
Member Author

clemsos commented Mar 26, 2019

For now, let's archive all viz in repo. No 3rd part, iframe or other unreliable solutions

can fetch from blo.cks.org using https://www.npmjs.com/package/blockfetcher

@clemsos clemsos closed this as completed Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants