Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should equals only compare place and not value? #13

Open
Ambrevar opened this issue Jul 13, 2022 · 2 comments
Open

Should equals only compare place and not value? #13

Ambrevar opened this issue Jul 13, 2022 · 2 comments

Comments

@Ambrevar
Copy link
Member

In atlas-engineer/nyxt#2451 we are manually replacing the existing setter handler. This is most certainly something that nhooks should do for us by default.

One possible fix is to change equals so that it only compares the place, and not the value.
But then the notion of equality is a bit dubious.

Alternatively, keep equals as it is and just add another check in add-hook to remove existing setter.

@aartaka Thoughts?

@aartaka
Copy link
Contributor

aartaka commented Jul 13, 2022

I've not used setter handlers and am unaware of how to actually use those, so I've no idea regarding this change :)

Do we have any documentation and examples of those?

@Ambrevar
Copy link
Member Author

Documentation is in the slots, but examples and tests are lacking. Something more to fix! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants