Support id selectors #80
Open
+63
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhsianw
reviewed
Sep 14, 2023
| @@ -51,7 +51,7 @@ export const getRegularClassesMap = (ast: gASTNode): classMapType => { | |||
| fp.map('content'), | |||
| fp.filter({ type: 'ident' }), | |||
| fp.flatMap('content'), | |||
| fp.filter({ type: 'class' }), | |||
| fp.filter(node => node.is('class') || node.is('id')), | |||
There was a problem hiding this comment.
Love the initiative! A small suggestion here: This function is intended to return regular classes. What do you think about creating a new one for retrieving ids or renaming the function?
There was a problem hiding this comment.
Renamed the function because it would be a shame to have to go over the ast one more time just for that
yuhsianw
reviewed
Sep 14, 2023
Comment on lines
+365
to
+373
| test({ | ||
| code: ` | ||
| import s from './id.scss'; | ||
|
|
||
| export default Foo = () => ( | ||
| <div id={s.scopedId}></div> | ||
| ); | ||
| `, | ||
| }), |
There was a problem hiding this comment.
Does this work with no-unused-class as well?
There was a problem hiding this comment.
Added tests for no-unused-class as well as an error test for no-undef-class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54