-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response matrices #893
base: master
Are you sure you want to change the base?
Response matrices #893
Conversation
@lfarv, thanks for this very nice addtion. A predefined OpticsResponseMatrix would be very useful as well. |
I think @ZeusMarti was also interested in RDT response matrix |
Yes! Thanks @swhite2401 ! Also, now that you are developing this, I was wondering if the response matrix formula for thick elements (should be not much slower than the optics calculation but very close to the numerical much slower calculation) and the derivative w.r.t. quadrupole strengths could also be added. I'm not sure AT is the place but what do you think? |
The analytical responses would certainly be a very nice addition to AT! I have discussed this with @simoneliuzzo who has already everything implemented in python, someone just has to find time to clean it up and make it work within AT |
@swhite2401, @ZeusMarti, @simoneliuzzo: thanks for your remarks: a lot of interesting new developments!
To progress step by step, I'd like to check here that the proposed generic interface is convenient. |
The ORM analytical computation is added as a new |
Corrected a bug reported in #903. |
Something that would be very interesting is to point to linopt outputs, in particular, phases, betas and dispersion that are generally used in linear optics correction algorithms. |
I would rather use: |
1933bf0
to
50e677d
Compare
The methods for filling a response matrix are renamed as;
For optics responses: since all the outputs of |
Subclasses would be very helpful for users |
For me, this version is ready for merging. Its the basis for the next steps. These could be:
Please try and comment… |
This PR adds the computation of response matrices. Please check the documentation here.