Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: be able to specify localhost with port as endpoint using config #29

Open
robpridham-bbc opened this issue Aug 3, 2020 · 1 comment

Comments

@robpridham-bbc
Copy link

robpridham-bbc commented Aug 3, 2020

As a developer, I would like to be able to direct the ATI library's network requests to e.g. https://localhost:9000/endpoint so that I can write instrumented end-to-end tests that use a mock HTTP server on the device and verify that the right calls are made.

In the documentation for Configuration, it appears that we can set subdomain, domain and path in order to achieve this.

However:

  • It would be good to be able to omit subdomain, perhaps by specifiying an empty string as log or logSSL. Currently this seems to stop production of all requests, and it looks like the code in Builder will always add a period separator, so that's probably why. To send to localhost we would therefore have to use a workaround with a subdomain of 127 and a domain of 0.0.1.

  • It would be good to be able to specify a port. This is not currently a documented option in config.

Thanks!

@robpridham-bbc robpridham-bbc changed the title Can't redirect output to a local endpoint using 'domain' in config Can't specify localhost as endpoint using config Aug 3, 2020
@robpridham-bbc robpridham-bbc changed the title Can't specify localhost as endpoint using config Feature request: be able to specify localhost with port as endpoint using config Aug 3, 2020
@BenDz
Copy link
Member

BenDz commented Aug 12, 2020

@robpridham-bbc Thanks for your feedback and sorry for the delay!
We will think about adding the capacity to manage a collect endpoint without any period.
Regarding the port, you can already add it in the domain configuration, this should work.
In your case, you should probably use this configuration:
log/logSSL: 127
domain: 0.0.1:9000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants