Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema minimum and maximum field data type change #97

Closed
ivanalayan15 opened this issue May 4, 2022 · 3 comments · Fixed by #100
Closed

Schema minimum and maximum field data type change #97

ivanalayan15 opened this issue May 4, 2022 · 3 comments · Fixed by #100
Assignees
Labels
enhancement New feature or request

Comments

@ivanalayan15
Copy link

Reason/Context

Please try answering few of those questions

  • Why we need this improvement?
    To handle different number data types
  • How will this change help?
    We can handle not only integer data types but also other type in min and max validation
  • What is the motivation?

Description

Currently our minimum and maximum field is in integer format we need to support other data type such 

as double/float/big decimal when having some decimal min and max range

  • What changes have to be introduced?
    Change of minimum and maximum data type
  • Will this be a breaking change?
    Data type change will always have breakage specially when its being use already.
  • How could it be implemented/designed?
    Just change the data type.
@ivanalayan15 ivanalayan15 added the enhancement New feature or request label May 4, 2022
ivanalayan15 pushed a commit to ivanalayan15/jasyncapi that referenced this issue May 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added stale and removed stale labels Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jan 1, 2023
@Pakisan
Copy link
Member

Pakisan commented Feb 15, 2023

#126

@Pakisan Pakisan closed this as completed Feb 15, 2023
@Pakisan Pakisan removed the stale label Mar 12, 2023
@Pakisan Pakisan self-assigned this Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants