Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set to true/false the property additionalProperties in Schema class #79

Closed
tmoreno opened this issue Feb 3, 2022 · 7 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@tmoreno
Copy link

tmoreno commented Feb 3, 2022

Description

According to examples found in modelina project, the property "additionalProperties" can be: true, false or a map, but jasyncapi only admit Schema objects. Please see this example (or any other):

https://github.com/asyncapi/modelina/blob/master/test/blackbox/docs/JsonSchemaDraft-7/asyncapi-2_0.json

In the spec reference page, this property is not documented.

I would like to be able to set this property to true or false, because java classes generated by modelina are affected by this property.

This is an extract from documentation (https://github.com/asyncapi/modelina/blob/master/docs/interpretation_of_JSON_Schema.md):

additionalProperties are interpreted as is, where duplicate additionalProperties for the model are merged. If the schema does not define additionalProperties it defaults to true schema.

@tmoreno tmoreno added the enhancement New feature or request label Feb 3, 2022
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 4, 2022
@github-actions github-actions bot removed the stale label Jul 29, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Nov 27, 2022
@Pakisan
Copy link
Member

Pakisan commented Mar 12, 2023

@tmoreno done

#126

@Pakisan Pakisan closed this as completed Mar 12, 2023
@Pakisan Pakisan removed the stale label Mar 12, 2023
@Pakisan Pakisan self-assigned this Mar 12, 2023
@thushalya
Copy link

thushalya commented Mar 21, 2023

wouldn't this is the case in apicurio data model?

I have added a StackOverflow question and an issue in apicurio also, just want to confirm this is the scenario

https://stackoverflow.com/questions/75802008/asyncapi-apicurio-data-model-additionapropertiestrue

@Pakisan

@Pakisan Pakisan reopened this Mar 21, 2023
@Pakisan
Copy link
Member

Pakisan commented Mar 21, 2023

@tmoreno hi!

Check out this merged pr. We double checked correctness of changes - additionalProperties can be boolean or Schema
#131

wouldn't this is the case in apicurio data model?

Will check it as soon as possible. The answer, for now, is I don't know because folks from Red Hat are using their own way to handle AsyncAPI specification

@Pakisan
Copy link
Member

Pakisan commented Apr 2, 2023

@Pakisan Pakisan closed this as completed May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants