Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SASL Security Scheme types #104

Closed
conor-ward opened this issue May 25, 2022 · 3 comments
Closed

Support SASL Security Scheme types #104

conor-ward opened this issue May 25, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@conor-ward
Copy link

Reason/Context

Please try answering few of those questions

  • Why we need this improvement?
    • SASL security scheme are supported in AsyncAPI 2.1.0 and later. For interacting with Kafka services it is useful to have SASL supported in this library also.
  • How will this change help?
    • It will allow users to document their authentication type

Description

Please try answering few of those questions

  • What changes have to be introduced?
    • I think adding the necessary SASL types to the SecurityScheme enum. I'm not sure what else would be needed.
  • Will this be a breaking change?
    • It shouldn't be as it is adding types

I'm not sure if this is possible as the AsyncAPI version supported in this library is 2.0.0 so I'm not sure if updating this to allow 2.1.0 or later would mean having to add more functionality than just adding SASL to the Security Schemes. So this Issue/Feature Request could be a lot bigger than just adding a Security Scheme.

@conor-ward conor-ward added the enhancement New feature or request label May 25, 2022
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 23, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2023
@Pakisan Pakisan reopened this Feb 15, 2023
@Pakisan
Copy link
Member

Pakisan commented Feb 15, 2023

@conor-ward implemented in 2.6.0 draft

#126

@Pakisan Pakisan closed this as completed Feb 15, 2023
@Pakisan Pakisan removed the stale label Mar 12, 2023
@Pakisan Pakisan self-assigned this Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants