From d4e5581f2ddb6c5b60a76fd6254367d334d7b5bb Mon Sep 17 00:00:00 2001 From: Adi-204 Date: Sun, 9 Feb 2025 13:19:12 +0530 Subject: [PATCH 1/3] fix: print in CLI asyncapi generate models without -o flag --- src/commands/generate/models.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commands/generate/models.ts b/src/commands/generate/models.ts index 5c7a04f82a2..a46977d2ac5 100644 --- a/src/commands/generate/models.ts +++ b/src/commands/generate/models.ts @@ -58,7 +58,7 @@ export default class Models extends Command { s.start('Generating models...'); try { const generatedModels = await generateModels({...flags, output}, document, logger, language as Languages); - if (output !== 'stdout') { + if (output && output !== 'stdout') { const generatedModelStrings = generatedModels.map((model) => { return model.modelName; }); s.stop(green(`Successfully generated the following models: ${generatedModelStrings.join(', ')}`)); return; From 013c25621c8e96950f9bdb33b6559b5cf2da6316 Mon Sep 17 00:00:00 2001 From: Moderator <60972989+AayushSaini101@users.noreply.github.com> Date: Sat, 15 Feb 2025 13:36:07 +0530 Subject: [PATCH 2/3] Create sour-clouds-heal.md --- .changeset/sour-clouds-heal.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/sour-clouds-heal.md diff --git a/.changeset/sour-clouds-heal.md b/.changeset/sour-clouds-heal.md new file mode 100644 index 00000000000..dbe133311f4 --- /dev/null +++ b/.changeset/sour-clouds-heal.md @@ -0,0 +1,5 @@ +--- +"@asyncapi/cli": patch +--- + +fix: print in cli asyncapi generate models without -o flag From e5e03b1307ce5012ce5427599527f64e55c2c7aa Mon Sep 17 00:00:00 2001 From: Adi-204 Date: Sat, 15 Feb 2025 14:59:57 +0530 Subject: [PATCH 3/3] test: added test for without output flag --- test/integration/generate/models.test.ts | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/test/integration/generate/models.test.ts b/test/integration/generate/models.test.ts index 2aa4bf59fab..8b4caa35a38 100644 --- a/test/integration/generate/models.test.ts +++ b/test/integration/generate/models.test.ts @@ -24,12 +24,21 @@ describe('models', () => { ); done(); }); - + + test + .stderr() + .stdout() + .command([...generalOptions, 'typescript', './test/fixtures/specification.yml']) + .it('works when file path is passed without specified output directory', (ctx, done) => { + expect(ctx.stdout).to.match(/Successfully generated the following models:\s+## Model name:/); + done(); + }); + test .stderr() .stdout() .command([...generalOptions, 'typescript', './test/fixtures/specification.yml', `-o=${ path.resolve(outputDir, './ts')}`]) - .it('works when file path is passed', (ctx, done) => { + .it('works when file path is passed with specified output directory', (ctx, done) => { expect(ctx.stdout).to.contain( 'Successfully generated the following models: ' );