Skip to content

Commit 428057d

Browse files
authored
fix: upload release assets not working (#1440)
1 parent 50d9fb1 commit 428057d

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

.github/workflows/upload-release-assets.yml

+7-2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ jobs:
1212
name: Generate and upload assets
1313
if: startsWith(github.event.commits[0].message, 'chore(release):')
1414
runs-on: ${{ matrix.os }}
15+
continue-on-error: true
1516
strategy:
1617
matrix:
1718
include:
@@ -23,11 +24,11 @@ jobs:
2324
npm_script: pack:tarballs
2425
dist_folder: tar
2526
extension: tar.gz
26-
- os: windows-latest
27+
- os: ubuntu-latest
2728
npm_script: pack:windows
2829
dist_folder: win32
2930
extension: x64.exe
30-
- os: windows-latest
31+
- os: ubuntu-latest
3132
npm_script: pack:windows
3233
dist_folder: win32
3334
extension: x86.exe
@@ -57,6 +58,10 @@ jobs:
5758
const packageJson = require('./package.json');
5859
const packageJsonVersion = packageJson.version;
5960
core.setOutput('version', packageJsonVersion);
61+
- if: matrix.npm_script == 'pack:windows':
62+
#fix for windows build issue #1433
63+
name: Install p7zip-full nsis
64+
run: sudo apt-get install -y p7zip-full nsis
6065
- if: steps.lockversion.outputs.version == '18' && matrix.os == 'windows-latest'
6166
#npm cli 10 is buggy because of some cache issue
6267
name: Install npm cli 8

0 commit comments

Comments
 (0)