Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DataPack parsing to backend #230

Open
mylibrar opened this issue Jun 21, 2022 · 0 comments · May be fixed by #232
Open

Migrate DataPack parsing to backend #230

mylibrar opened this issue Jun 21, 2022 · 0 comments · May be fixed by #232
Labels
feature request Request a new feature

Comments

@mylibrar
Copy link
Collaborator

mylibrar commented Jun 21, 2022

Is your feature request related to a problem? Please describe.
Stave is maintaining a manual DataPack parsing function in its frontend codebase, which is susceptible to any updates on the serialization schema in Forte. We already have the DataPack serialization/deserialization implemented in Forte, and it might be hard to maintain two DataPack parsing systems at the same time. A more reasonable solution is to migrate the parsing logics to backend and let Forte handle most of the encoding/decoding work of DataPack.

Describe the solution you'd like

  • Utilize DataPack.from_string() and DataPack.to_string() for parsing and encoding.
  • Certain backend API should be updated.
  • Frontend logics should also be changed correspondingly.

Describe alternatives you've considered
We might also need to refactor some of the handlers in stave_viewer.py to ensure that StaveProcessor won't break.

Additional context

@mylibrar mylibrar added the feature request Request a new feature label Jun 21, 2022
@mylibrar mylibrar linked a pull request Jul 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant