Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Baart's criteria as a standalone selector object #98

Open
dwysocki opened this issue Dec 28, 2015 · 0 comments
Open

Implement Baart's criteria as a standalone selector object #98

dwysocki opened this issue Dec 28, 2015 · 0 comments

Comments

@dwysocki
Copy link
Member

We currently have some hackery in place to deal with the selection of GridSearchCV versus Baart. Instead of implementing Baart's criteria as a selector object, like GridSearchCV, we have it as an option in the Fourier class.

It would be much better if we created a standalone Baart class, which obeyed the same interface as GridSearchCV. This would allow us to simplify the rest of the codebase, and more easily allow for arbitrary selectors, as described in #91.

As another thought, it may be better yet to implement a more general selector object, which takes an arbitrary stopping_criteria function, which could then be set to baarts_criteria or any other function. I wonder if such a thing already exists...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant