Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary phasing of data #77

Open
dwysocki opened this issue Aug 30, 2015 · 1 comment
Open

Remove unnecessary phasing of data #77

dwysocki opened this issue Aug 30, 2015 · 1 comment

Comments

@dwysocki
Copy link
Member

There are cases where we phase the data, and others where we use temporal data. So long as we bake the period into our predictor objects, this won't be necessary. Also, removing the distinction between phased/unphased data would make the code a lot easier to work with, and the API a lot more useful.

Doing this is a non-trivial task, due to the number of places which depend on the data being phased/unphased. While I would like to see this done in the release which we publish, for the sake of time I think it needs to be a future release.

@dwysocki dwysocki added this to the Engineering goals milestone Aug 30, 2015
@dwysocki dwysocki mentioned this issue Nov 1, 2015
14 tasks
@dwysocki
Copy link
Member Author

dwysocki commented Nov 2, 2015

I'm going to start compiling a list of places I notice a reliance on phased data. If we start writing them down as we see them, it will be a lot easier when one of us finally goes through and fixes them all, and then there will be a checklist to make sure they're all fixed. (feel free to edit this post)

  • placeholder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant