-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdss-v mwmVisit data loaders broken #1182
Comments
@rileythai do you have time to look into this? If not, I can. A relevant id is "54459273". Separately, we also need to add a new loader for the astra aspcap model spectra. |
I have time this weekend -- this should be a simple fix. |
Great - we just merged another bug fix, I can wait to do a bug fix release until early next week if you can get this done by then. Thanks! |
The SDSS-V data loader for
mwmVisit
fails to loadmwmVisit
files that only have BOSS-extension data in them. It loads fine formwmVisit
files with only APOGEE-extension data. I think the issue is during metadata collection, it looks for info specific to certain extensions but not all. e.g. seespecutils/specutils/io/default_loaders/sdss_v.py
Line 589 in 67bea40
We could either remove the metadata entirely as it's not strictly necessary to load the spectrum, or adjust this code. This is a blocker for sdss/sdss_solara#9
Either I or relevant folks can fix, just creating an issue for tracking.
The text was updated successfully, but these errors were encountered: