Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdss-v mwmVisit data loaders broken #1182

Open
havok2063 opened this issue Oct 10, 2024 · 4 comments
Open

sdss-v mwmVisit data loaders broken #1182

havok2063 opened this issue Oct 10, 2024 · 4 comments

Comments

@havok2063
Copy link
Contributor

The SDSS-V data loader for mwmVisit fails to load mwmVisit files that only have BOSS-extension data in them. It loads fine for mwmVisit files with only APOGEE-extension data. I think the issue is during metadata collection, it looks for info specific to certain extensions but not all. e.g. see

meta["date"] = hdulist[hdu].data["date_obs"]

We could either remove the metadata entirely as it's not strictly necessary to load the spectrum, or adjust this code. This is a blocker for sdss/sdss_solara#9

Either I or relevant folks can fix, just creating an issue for tracking.

@havok2063
Copy link
Contributor Author

@rileythai do you have time to look into this? If not, I can. A relevant id is "54459273". Separately, we also need to add a new loader for the astra aspcap model spectra.

@rileythai
Copy link
Contributor

I have time this weekend -- this should be a simple fix.

@rosteen
Copy link
Contributor

rosteen commented Oct 11, 2024

I have time this weekend -- this should be a simple fix.

Great - we just merged another bug fix, I can wait to do a bug fix release until early next week if you can get this done by then. Thanks!

@havok2063
Copy link
Contributor Author

Thanks @rosteen I'd also like to get #1183 in that fix if possible. If not, I'd like to get it in another release soon after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants