Issue 170 align spectrum along trace #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m_along_trace' and improved its docstring.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 83.33% 83.30% -0.03%
==========================================
Files 13 13
Lines 1140 1198 +58
==========================================
+ Hits 950 998 +48
- Misses 190 200 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #170 by introducing a utility function
specreduce.utils.align_2d_spectrum_along_traceto align a rectilinear 2D spectrum image along a trace. The function is based on thespecreduce.extract._align_along_tracefunction and adds (optional) sub-pixel precision shifting using linear interpolation, mask handling, and uncertainty propagation (when using the 'interpolate' method). I can change thespecreduce.extractcode to use the new function after @cshanahan1's masking code (PR #216) has been merged.