Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: better session handling in registry #590

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 27, 2024

This is kind of a follow-up for #490 and #447 and alike.

I cherry-picked the changes out of #470 as I would like to backport it to a bugfix release.

(I also added some minor service type docs cleanup as I spotted it while checking for all the usage of to_service())

@bsipocz bsipocz added this to the v1.5.3 milestone Aug 27, 2024
@bsipocz bsipocz requested a review from msdemlei August 27, 2024 23:00
@bsipocz
Copy link
Member Author

bsipocz commented Aug 27, 2024

cc @andamian - we run into a lot of connection issues with the CADC sia tests. Any insight, should we switch to hit a different server with those?

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are sensible changes, and from a quick check it would seem it passes session in all the places registry.regtap should pass it. CI failures all seem spurious and/or unrelated. Let's go.

Thanks!

@msdemlei msdemlei merged commit 4af9b46 into astropy:main Aug 28, 2024
9 of 10 checks passed
@bsipocz bsipocz deleted the BUG_session_handling_in_registry branch August 29, 2024 17:02
bsipocz pushed a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants