You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While their usage seems convenient at first, at the end of the day there are a lot of issues with hiding the details rather then be explicit in an API signature. Just a few of the issues:
they can swallow arguments without being actually used
Hm – I think I understand your rationale, although I have to say I still like the idea that people can just inherit from Constraint and roll their own sorts of constraints for regtap.py. On the other hand, I think I am resigned into the realisation that the keywords won't disappear as legacy.
Be that as it may: What concrete steps do you have in mind? Scrap the _author thing in rtcons Constraints and make these somehow explicit in regtap.search and regtap.get_RegTAP_query? I have to admit that having to repeat that long list of keyword arguments makes me immediately unhappy...
And as to *constraints... Hm. What would you do instead? The interface rather plainly is "pass in zero or more Constraint objects", and I don't there's not much of a good alternative to that. Of course, we could go all-keyword, but for one the keywords are less expressive, and for a second they won't let me pass in two constraints of the same kind (unless I started to accept both sequences and atoms throughout; again, that feels like a recipe for unhappyness), which seems a bit restrictive to me.
While their usage seems convenient at first, at the end of the day there are a lot of issues with hiding the details rather then be explicit in an API signature. Just a few of the issues:
The text was updated successfully, but these errors were encountered: