Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for numpy 2 #1084

Open
aphearin opened this issue Aug 27, 2024 · 1 comment
Open

Add support for numpy 2 #1084

aphearin opened this issue Aug 27, 2024 · 1 comment
Assignees

Comments

@aphearin
Copy link
Contributor

In #1083 the dependency chain added a requirement numpy<2. The reason was that none of our CI was running due to some unknown incompatibility with numpy 2. So we kicked the can down the road on support for numpy 2, but this should be restored once numpy 2 incompatibility causes issues with common environments.

@aphearin
Copy link
Contributor Author

aphearin commented Dec 2, 2024

According to this failed job log, one of the issues with the cython has to do with how cython arrays of integer type are declared:

cdef vector[np.int_t] j_ind

The Numpy 2.0 migration guide has a few comments about this here.

In addition to changing the way integer arrays are declared, a separate fix using the import_array() mechanism may also be required according to this section of the migration guide.

@aphearin aphearin self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant