Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dec_to_zone should use AxsFrame zone height rather than the default value #24

Open
ebellm opened this issue Aug 26, 2020 · 0 comments
Open

dec_to_zone should use AxsFrame zone height rather than the default value #24

ebellm opened this issue Aug 26, 2020 · 0 comments

Comments

@ebellm
Copy link

ebellm commented Aug 26, 2020 •
edited
Loading

The current dec_to_zone function hard-codes defaults the zone height to Constants.ONE_AMIN. When called in AxsFrame.region and AxsFrame.cone, it should used the zone height stored in metadata (at _table_info['zone_height']), otherwise region and cone-search function calls will fail for tables stored with other zone heights.
@ebellm ebellm changed the title dec_to_zone should not hard-code the zone height dec_to_zone should use AxsFrame zone height rather than the default value Aug 26, 2020
@ctslater ctslater mentioned this issue Oct 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ebellm