From 8341c82a3a7ba4b02d6b29e2968896493660f25c Mon Sep 17 00:00:00 2001 From: Wei Lee Date: Tue, 9 Apr 2024 16:02:56 +0800 Subject: [PATCH 1/2] fix(google): output is deprecated in BigQueryFacets, outputs should be used instead --- astronomer/providers/google/cloud/extractors/bigquery.py | 2 +- tests/google/cloud/extractors/test_bigquery.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/astronomer/providers/google/cloud/extractors/bigquery.py b/astronomer/providers/google/cloud/extractors/bigquery.py index 1e72623f4..5aeda6401 100644 --- a/astronomer/providers/google/cloud/extractors/bigquery.py +++ b/astronomer/providers/google/cloud/extractors/bigquery.py @@ -107,7 +107,7 @@ def extract_on_complete(self, task_instance: TaskInstance) -> Optional[TaskMetad stats = BigQueryDatasetsProvider(client=self._big_query_client).get_facets(bigquery_job_id) inputs = stats.inputs - output = stats.output + output = stats.outputs run_facets = stats.run_facets job_facets = {} if isinstance( diff --git a/tests/google/cloud/extractors/test_bigquery.py b/tests/google/cloud/extractors/test_bigquery.py index 9b035a3fa..e558b2b2c 100644 --- a/tests/google/cloud/extractors/test_bigquery.py +++ b/tests/google/cloud/extractors/test_bigquery.py @@ -88,7 +88,7 @@ def test_extract_on_complete( job_id=job_id, error_result=False ) mock_bg_dataset_provider.return_value = BigQueryFacets( - run_facets=RUN_FACETS, inputs=INPUT_STATS, output=OUTPUT_STATS + run_facets=RUN_FACETS, inputs=INPUT_STATS, outputs=OUTPUT_STATS ) task_id = "insert_query_job" From d15f8aecd61067756b7bd83d4171fb67f5208759 Mon Sep 17 00:00:00 2001 From: Wei Lee Date: Tue, 9 Apr 2024 16:12:31 +0800 Subject: [PATCH 2/2] style(core): fix mypy warning --- astronomer/providers/core/sensors/filesystem.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/astronomer/providers/core/sensors/filesystem.py b/astronomer/providers/core/sensors/filesystem.py index 1ed91f13f..53258d5a5 100644 --- a/astronomer/providers/core/sensors/filesystem.py +++ b/astronomer/providers/core/sensors/filesystem.py @@ -1,7 +1,9 @@ +from __future__ import annotations + import os import warnings from datetime import timedelta -from typing import Any, Dict, Optional +from typing import Any from airflow.hooks.filesystem import FSHook from airflow.sensors.filesystem import FileSensor @@ -54,7 +56,7 @@ def execute(self, context: Context) -> None: method_name="execute_complete", ) - def execute_complete(self, context: Context, event: Optional[Dict[str, Any]]) -> None: + def execute_complete(self, context: Context, event: bool | None = None) -> None: """ Callback for when the trigger fires - returns immediately. Relies on trigger to throw an exception, otherwise it assumes execution was