From 8d7e55d638fddeb1b4d7fe77df1736e9f1162e45 Mon Sep 17 00:00:00 2001 From: Pankaj Date: Sat, 20 Jan 2024 00:17:03 +0530 Subject: [PATCH 1/3] Add deprecation warrning in core provider --- .../providers/core/sensors/external_task.py | 10 ++++++++++ astronomer/providers/core/sensors/filesystem.py | 16 ++++++++++++++++ 2 files changed, 26 insertions(+) diff --git a/astronomer/providers/core/sensors/external_task.py b/astronomer/providers/core/sensors/external_task.py index f7e96d494..574aa19ca 100644 --- a/astronomer/providers/core/sensors/external_task.py +++ b/astronomer/providers/core/sensors/external_task.py @@ -1,4 +1,5 @@ import datetime +import warnings from typing import TYPE_CHECKING, Any, Dict, List, Optional from airflow.sensors.external_task import ExternalTaskSensor @@ -23,6 +24,15 @@ def __init__( poke_interval: float = 5.0, **kwargs: Any, ) -> None: + warnings.warn( + ( + "This module is deprecated and will be removed in airflow>=2.9.0" + "Please use `airflow.sensors.external_task.ExternalTaskSensor` " + "and set deferrable to True instead." + ), + DeprecationWarning, + stacklevel=2, + ) super().__init__(**kwargs) self.poke_interval = poke_interval diff --git a/astronomer/providers/core/sensors/filesystem.py b/astronomer/providers/core/sensors/filesystem.py index e965139a9..10711d9e0 100644 --- a/astronomer/providers/core/sensors/filesystem.py +++ b/astronomer/providers/core/sensors/filesystem.py @@ -1,4 +1,5 @@ import os +import warnings from datetime import timedelta from typing import Any, Dict, Optional @@ -22,6 +23,21 @@ class FileSensorAsync(FileSensor): :param recursive: when set to ``True``, enables recursive directory matching behavior of ``**`` in glob filepath parameter. Defaults to ``False``. """ + def __init__( + self, + *args, + **kwargs + ): + warnings.warn( + ( + "This module is deprecated and will be removed in airflow>=2.9.0" + "Please use `airflow.sensors.filesystem.FileSensor` " + "and set deferrable to True instead." + ), + DeprecationWarning, + stacklevel=2, + ) + super().__init__(*args, **kwargs) def execute(self, context: Context) -> None: """Airflow runs this method on the worker and defers using the trigger.""" From 6b3971ad4fab1088c1c5aa44aa1aef287c27f162 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 19 Jan 2024 18:49:22 +0000 Subject: [PATCH 2/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- astronomer/providers/core/sensors/filesystem.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/astronomer/providers/core/sensors/filesystem.py b/astronomer/providers/core/sensors/filesystem.py index 10711d9e0..39512f6e1 100644 --- a/astronomer/providers/core/sensors/filesystem.py +++ b/astronomer/providers/core/sensors/filesystem.py @@ -23,11 +23,8 @@ class FileSensorAsync(FileSensor): :param recursive: when set to ``True``, enables recursive directory matching behavior of ``**`` in glob filepath parameter. Defaults to ``False``. """ - def __init__( - self, - *args, - **kwargs - ): + + def __init__(self, *args, **kwargs): warnings.warn( ( "This module is deprecated and will be removed in airflow>=2.9.0" From 702f7c9e5e9e6d4d448a521158a2599ff2562566 Mon Sep 17 00:00:00 2001 From: Pankaj Date: Sat, 20 Jan 2024 00:25:08 +0530 Subject: [PATCH 3/3] Add deprecation warning in core provider --- astronomer/providers/core/triggers/external_task.py | 10 ++++++++++ astronomer/providers/core/triggers/filesystem.py | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/astronomer/providers/core/triggers/external_task.py b/astronomer/providers/core/triggers/external_task.py index 720d37cc3..0158e96cf 100644 --- a/astronomer/providers/core/triggers/external_task.py +++ b/astronomer/providers/core/triggers/external_task.py @@ -1,6 +1,7 @@ import asyncio import datetime import typing +import warnings from typing import Any, AsyncIterator, Dict, List, Tuple from airflow import AirflowException @@ -105,6 +106,15 @@ def __init__( execution_dates: List[datetime.datetime], poll_interval: float = 5.0, ): + warnings.warn( + ( + "This module is deprecated and will be removed in airflow>=2.9.0" + "Please use `airflow.triggers.external_task.WorkflowTrigger` " + "and set deferrable to True instead." + ), + DeprecationWarning, + stacklevel=2, + ) super().__init__() self.dag_id = dag_id self.states = states diff --git a/astronomer/providers/core/triggers/filesystem.py b/astronomer/providers/core/triggers/filesystem.py index b195a3a5c..3b7564155 100644 --- a/astronomer/providers/core/triggers/filesystem.py +++ b/astronomer/providers/core/triggers/filesystem.py @@ -2,6 +2,7 @@ import datetime import os import typing +import warnings from glob import glob from typing import Any, Dict, Tuple @@ -26,6 +27,15 @@ def __init__( recursive: bool = False, poll_interval: float = 5.0, ): + warnings.warn( + ( + "This module is deprecated and will be removed in airflow>=2.9.0" + "Please use `airflow.triggers.file.FileTrigger` " + "and set deferrable to True instead." + ), + DeprecationWarning, + stacklevel=2, + ) super().__init__() self.filepath = filepath self.recursive = recursive