Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code bloat and improve hygiene #68

Open
5 of 6 tasks
fjebaker opened this issue Jan 20, 2023 · 0 comments
Open
5 of 6 tasks

Remove code bloat and improve hygiene #68

fjebaker opened this issue Jan 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@fjebaker
Copy link
Member

fjebaker commented Jan 20, 2023

The project is a little over a year old now and the code bloat is apparent.

Need to go through each function with a fine toothed comb and see what can be made leaner, or even just removed entirely. Also there are a number of bad habits that should be corrected, such as

  • remove always using where {T} unless actually needed
  • anonymous lambda functions are difficult to debug, give them names
  • function names and extraction API, e.g. getgeodesicpoint vs just process, as that is what it's really doing.
  • Keyword arguments passed to solver in orbit finder #16

Also worth looking into

before getting too carried away with more features.

@fjebaker fjebaker added the enhancement New feature or request label Jan 20, 2023
@fjebaker fjebaker moved this to Todo 🐣 in Gradus.jl Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo 🐣
Development

No branches or pull requests

1 participant