Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image planes can mismatch the desired sampled region #156

Open
Tracked by #159
fjebaker opened this issue Sep 4, 2023 · 1 comment
Open
Tracked by #159

Image planes can mismatch the desired sampled region #156

fjebaker opened this issue Sep 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@fjebaker
Copy link
Member

fjebaker commented Sep 4, 2023

If the outer radius on the image plane is not a few factors of maxrₑ, which may occur if a user is specifying the plane, then there is no warning that the sampled region may not actually be the desired region.

The image_plane function should be reworked, so that the planes themselves store parameters of the plane, but the size of it is scaled internally, so that this mistmatch cannot occur.

This should also still be useable in the rendergeodesic functions however, so some care in the design needs to be taken.

@fjebaker fjebaker added the bug Something isn't working label Sep 4, 2023
@fjebaker fjebaker mentioned this issue Sep 6, 2023
13 tasks
@fjebaker
Copy link
Member Author

fjebaker commented Sep 9, 2023

Same applies for the inner radius, especially in the context of obscured discs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant