Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear unwrap inside core execution logic #1769

Open
SuperFluffy opened this issue Oct 30, 2024 · 3 comments · May be fixed by #1772
Open

Unclear unwrap inside core execution logic #1769

SuperFluffy opened this issue Oct 30, 2024 · 3 comments · May be fixed by #1772
Assignees
@Lilyjjo
Labels
ignore-stale Override for issues or PRs which should not be removed if stale. stale

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Oct 30, 2024 •
edited by sync-by-unito bot
Loading

astria_sequencer::App::execute_transaction_prepare_proposal [1] unwraps a Result. The expect message it provides does not give any indication why unwrapping at that point is acceptable. Tracing it through the stack the error that is being bubbled up comes from a call deep inside astria_sequencer::Mempool::builder_queue [2] and [3].

It is not clear why this expect here is acceptable or why it is an invariant of the system that the return value of of the method call is always Ok.

1:

astria/crates/astria-sequencer/src/app/mod.rs

Line 589 in ca72c64

.expect("failed to fetch pending transactions");

2:

astria/crates/astria-sequencer/src/mempool/mod.rs

Line 298 in ca72c64

self.pending.read().await.builder_queue(state).await

3:

astria/crates/astria-sequencer/src/mempool/transactions_container.rs

Line 773 in ca72c64

pub(super) async fn builder_queue<S: accounts::StateReadExt>(

The code that introduced this was #1323.

┆Issue Number: ENG-960
@Lilyjjo Lilyjjo linked a pull request Oct 31, 2024 that will close this issue
Open
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@joroshiba
Copy link
Member

This issue was closed because it was stale

@joroshiba joroshiba closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2024
@SuperFluffy SuperFluffy added the ignore-stale Override for issues or PRs which should not be removed if stale. label Jan 6, 2025
@SuperFluffy
Copy link
Member Author

Reopening because it's actively tracked by PR #1772

@SuperFluffy SuperFluffy reopened this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lilyjjo Lilyjjo

Labels
ignore-stale Override for issues or PRs which should not be removed if stale. stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sequencer): remove unwrap from app utilized mempool logic astriaorg/astria
3 participants
@joroshiba @SuperFluffy @Lilyjjo