Avoid downgrading packages when --upgrade is provided
#10097
+179
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/downgrade
branch
from
5ea3765 to
1059071
Compare
charliermarsh
force-pushed
the
charlie/downgrade
branch
from
1059071 to
032bfa6
Compare
|
(No reviews please, need to get tests passing.) |
charliermarsh
force-pushed
the
charlie/downgrade
branch
4 times, most recently
from
7f3d738 to
b14fb9c
Compare
charliermarsh
force-pushed
the
charlie/downgrade
branch
from
b14fb9c to
2be9015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
--upgradeis provided, we should retain already-installed packages if they're newer than whatever is available from the registry.Closes #10089.