Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-pie] Allow cast(SomeType, ...) (PIE796) #15141

Merged
merged 2 commits into from
Dec 30, 2024
Merged

[flake8-pie] Allow cast(SomeType, ...) (PIE796) #15141

merged 2 commits into from
Dec 30, 2024
+64 −8

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #15132.

Test Plan

cargo nextest run and cargo insta test.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

MichaReiser
MichaReiser reviewed Dec 26, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This overall looks good to me. I've a small suggestion on how to change the code.

crates/ruff_linter/src/rules/flake8_pie/rules/non_unique_enums.rs Outdated Show resolved Hide resolved
@MichaReiser MichaReiser added the rule Implementing or modifying a lint rule label Dec 26, 2024
MichaReiser
MichaReiser approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MichaReiser MichaReiser merged commit 280ba75 into astral-sh:main Dec 30, 2024
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the PIE796 branch December 30, 2024 15:06
@BrewTestBot BrewTestBot mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
rule Implementing or modifying a lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PIE796 false-positives on enum member cast in pyi files
2 participants
@InSyncWithFoo @MichaReiser