Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Spliceout #140

Open
7 tasks
iver56 opened this issue May 6, 2022 · 0 comments
Open
7 tasks

Improve Spliceout #140

iver56 opened this issue May 6, 2022 · 0 comments
Milestone
v0.12.0

Comments

@iver56
Copy link
Collaborator

iver56 commented May 6, 2022 •
edited
Loading

Here are some ideas for Spliceout improvements:

  • Add a param for crossfade window size? 10 ms may actually be a bit on the large side for a default
  • Maybe try sqrt for crossfades instead of hann to avoid the perceived dip in energy in the crossfades
  • Improve the docstring (ELI5)
  • Rename max_width? And specify it in seconds instead of milliseconds.
  • Run black on the code
  • Mention it in README
  • Update changelog
@iver56 iver56 added this to the v0.11.0 milestone May 6, 2022
@iver56 iver56 mentioned this issue May 6, 2022
Closed
@iver56 iver56 mentioned this issue May 27, 2022
Merged
@iver56 iver56 modified the milestones: v0.11.0, v0.12.0 Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

No branches or pull requests
1 participant
@iver56