Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of librosa dependency in favor of torchaudio #134

Open
hbredin opened this issue Apr 13, 2022 · 3 comments
Open

Get rid of librosa dependency in favor of torchaudio #134

hbredin opened this issue Apr 13, 2022 · 3 comments
Assignees
@hbredin

Comments

@hbredin
Copy link
Collaborator

hbredin commented Apr 13, 2022

torchaudio now does a good job loading and resampling audio.

Would be nice to get rid of (sometimes tricky to install) librosa in favor of torchaudio.

Related: #9
@iver56
Copy link
Collaborator

iver56 commented Apr 13, 2022

Good! Yeah, I agree, let's get rid of the librosa dependency. I haven't followed the progress in torchaudio closely. Did they speed up their resampling since #37 (comment) ?

@Bomme
Copy link

Bomme commented May 10, 2022

Since version 0.8.0 the resampling in torchaudio is based on julius.

Leveraged julius resampling implementation to make resampling faster. (pytorch/audio#1087)

@hbredin hbredin self-assigned this May 19, 2022
@hbredin
Copy link
Collaborator Author

hbredin commented May 19, 2022

Related: https://pytorch.org/audio/stable/tutorials/audio_resampling_tutorial.html#comparison-against-librosa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hbredin hbredin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hbredin @iver56 @Bomme