Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian 10 (Buster) - dahdi-linux 3.4.0 - Compile - error: missing binary operator before token "(" #51

Open
jared-bloomer opened this issue Jun 21, 2024 · 1 comment · May be fixed by #58
Open

Debian 10 (Buster) - dahdi-linux 3.4.0 - Compile - error: missing binary operator before token "(" #51

jared-bloomer opened this issue Jun 21, 2024 · 1 comment · May be fixed by #58

Comments

@jared-bloomer
Copy link

OS: Debian 10 (Buster)
Kernel: 5.10.0-0.deb10.29-amd64
dahdi-linux release: 3.4.0

Issue:
I downloaded a fresh copy of of dahdi-linux-3.4.0.tar.gz. I extracted it, and cd into the directory. I then ran make and it failed with the following error

/root/dahdi-linux-3.4.0/drivers/dahdi/xpp/xbus-sysfs.c:424:43: error: missing binary operator before token "("
  RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(9,4)
InterLinked1 added a commit to InterLinked1/dahdi-linux that referenced this issue Sep 20, 2024
@InterLinked1
dahdi-sysfs, xbus-sysfs: Fix RHEL conditional compilation checks.
de9774b 
Commit d7bbc8a introduced
a regression for kernels older than 6.3.0 by not properly
guarding usage of the RHEL macros. Even though the logic
short-circuits, undefined macros can still be used this way,
so add another #if block to prevent using undefined macros.

Resolves: asterisk#51
InterLinked1 added a commit to InterLinked1/dahdi-linux that referenced this issue Sep 20, 2024
@InterLinked1
dahdi-sysfs, xbus-sysfs: Fix RHEL conditional compilation checks.
cff5c14 
Commit d7bbc8a introduced
a regression for non-RHEL distros using kernels older than
6.3.0 by not properly guarding usage of the RHEL macros.
Even though the logic short-circuits, undefined macros can
still be used this way, so add another #if block to prevent
using undefined macros.

Resolves: asterisk#51
@InterLinked1 InterLinked1 linked a pull request Sep 20, 2024 that will close this issue
Open
@InterLinked1
Copy link
Contributor

OS: Debian 10 (Buster) Kernel: 5.10.0-0.deb10.29-amd64 dahdi-linux release: 3.4.0

Issue: I downloaded a fresh copy of of dahdi-linux-3.4.0.tar.gz. I extracted it, and cd into the directory. I then ran make and it failed with the following error

/root/dahdi-linux-3.4.0/drivers/dahdi/xpp/xbus-sysfs.c:424:43: error: missing binary operator before token "("
  RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(9,4)

The new maintainer introduced a regression for this when trying to resolve the issue for RHEL systems. Here is a patch that resolves the issue and should allow you to build: #58

If you install using PhreakScript[1], it also has this (and other) fixes that may be needed.

[1] https://github.com/InterLinked1/phreakscript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dahdi-sysfs, xbus-sysfs: Fix RHEL conditional compilation checks. InterLinked1/dahdi-linux
2 participants
@InterLinked1 @jared-bloomer