-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customise cell Text Format #168
Comments
I've started working on this (as part of replacing the whole grid layout library with something better). Now I'm wondering about the details for the options of showing the text. See this screenshot, original at the top, my new experiments at the bottom: For now I'm just using a fixed font size at the bottom. My questions are: what should be default behavious and what should be configurable with which options? A suggestion for possible options:
@ms-mialingvo and @arasaac-dga please tell me what you think. |
Thank you!
font(-family) probably is whatever the browser's font is so it would be possible to change that there? |
Great!!! Good addtion. Our comments:
We add two more options one of them, the most requested:
In case of long long texts if after all the settings are longer than cell space, the best would be to truncate and add ... |
I made an error in reasoning, I think. If the maximum lines is set to two, I guess the system recognizes if a second line is needed and only adds it if it's needed? For some reason I thought having two lines as default would mean it would add an empty second line if the word was too short, which is why I said 1 line as default. If the system adapts automatically, though, I too am for 2 lines as default. If setting up font-family is a possibility, it would be important for me that one of the font is a font with the double-storey |a| and one is one with the single-storey |ɑ| (e.g. Futura) and that it still would automatically switch to the needed non-latin font (e.g. arab, devanagari) depending on the language of the board. I didn't mention text position as it's listed in the first post but that sure would be an important option too. |
Font-family and text position would be enough to have as global option only, I think. And then maybe font-size, line-height and maximum lines as both global option both as well as option on individual cells? I'm not quite sure if all 3 would be needed for individual cells. What do you think, arasaac-dga? Would the line-height automatically fix issue #403, @klues ? |
We also understand that although is set by default in two lines, the system automatically will use only one if two are not needed. The idea is set the max number of lines but not the lines that must be used.
Yes we agree. It's neccesary to offer fonts that are suitable for some languages as you comment. Perhaps it would be interesting that the system sets, by default, a font-family for some content languages or that, the font-family list of fonts, list only the font that are suitable for those languages.
We are worried about introducing more complexity in communicator management. That's why we think that font-size, line-height and maximum lines must be only as global options. Introducing more configurations in cells makes everything more complex for managers that, in our experience, have low technical level. |
So, I just casually stumbled upon a board set that has the labels to the right of the image. I don't know what the reason is for that person to create it like that. However it reminded me of #57 and for that one, it would be helpful to have that option. Like for some users, it will be more helpful to have the different steps not from left to right (or right to left in Arab) but from top to bottom. And then it would be better if the text was on the right of the image (or left in Arab). The question is, should right/left position only be possible for such procedure plans or for all buttons, like is it easier to just programm it right from the start as option for all buttons? (Also, at that point the position should also become editable not just per set but per button)
I think the way the editor is re-arranged and set up will have a big impact on that. Like for example in TD, most options are editable on set level, on page level and on button level. These are therefore a lot of options. However, because the settings are organised visually exactly the same for each level, it's really easy to understand and quite intuitive. |
Thanks for all your comments and thoughts! 👍 Instead of answering to everything separately I'll try to summarize all options and possibilities (also for me to have something to look at while implementing):
What should be default for
Currently I have some extra logic, which tries to increase the font-size of single character elements which is intended for keyboards. I would like to remove this extra logic and only use the new options. For this case 2 questions:
For the question of how to arrange options and settings, I have opened a new issue to discuss this separately: #452 |
Yes, we consider that, for other colors, different to black, white and yellow must be defined at grid or cell level only. Globally has no sense.
For us, text position on bottom by default as is now and color mode with backgroud color as is now too. Most of the commercial communicators use background color by default and is most used option (although we understand the need of frame color as option). Anyway, IMPORTANT, when you update Asterics with format text, the most important is that people don't see changes in their actual design. So, for example, if you decide, finally to set as default text on top, when you update don't chage this option for people. The same with others like line-height,font-size,.... It's important that the update is the most transparent as possible without generate "important" changes.
Yes, although we are not in favour of introducing more settings in order not to introduce more complexity, we agree that some formatting (appearance) configuration of the grid specifically will be necessary by modifying, as you propose in the other issue #452 the current resizing window of the grid. It is important that boards like the keyboard ones, for example, look good and have their own specific configuration since they can be single-letter keyboards, multi-letter keyboards (in Spanish no more than 3) or keyboards where we use pictograms/images. All the other options for format text/cell we agree with the proposal. |
We forgot to comment that we don't see the need of right/left text as global option for any case and in any case as global option. |
We are talking about font-size, but might image-size instead with automatic adaptation of font-size give more flexibility? "Let user define 0-100% of height of image/symbol, the font-size of the label adapts automatically to fit within the remaining space." #28 (0% image-size would then also equal to "hide all images", there was an issue open for that) Or does it end up being the same as it needs to add to 100% anyway?
As I don't know why pagesets with left/right text do exist, I'd have to ask actual AAC users first. It's a pity that there aren't more AAC users active in here.
Same. |
We consider more transparent for users config line-height as is planned (inside a global text configuration) and don't consider it useful to change the configuration to the image. We don't see the need to configure images globally and their size (don't see the need to set it to 0% to hide all the images). So, we prefer to continue with the actual way to configure Text-Images from Line-Height. It's more logical for us. |
I also think that
But in the end it makes no difference regarding flexibility, you could still set line-height to |
Totally agree @klues !!! |
Alright. I've been trying to figure out about the right/left labels and haven't been able to get any proper answer as to why this could be useful in some cases. So for me then, it also wouldn't be necessary to have right/left labels as global option, just for individual cells. |
Not directly related to this, but to have the same wording/style accross the settings: Edit: |
One last thing for the moment. I'd add some kind of informative sentence to Besides the bug named by arasaac-dga, I haven't found other bugs across devices so far. |
Actually
Really? What are the use-cases? Border / background color and font size is already possible to set on element level and for the other ones I think 99.99% of the users will not use them on element level, will they?
It's because the predict elements are bigger and the font-size is related to the total size of the element (width and height). And it's not only taking the height into account because it makes the font size more stable on screen orientation change (rotation) on mobile devices.
yeah, |
Okay, it's working in Firefox, it's Safari that's acting up ;) Or well, all browsers are acting up in general right now which makes it hard to test. On mobile (Firefox, iPhone) it looks like this: 2 lines, adapt automatically, font-size 12%. Doesn't look good. 2 lines, truncate/elipsis, font-size 12%. Looks good. Interestingly it also changes to this is if I move the mobile to vertical and then horizontal again while still in adapt automatically mode. For clarification, are the >1 lines combinable with truncate and elipsis so that it truncates/elipses after 2 or 3 lines? I have the feeling that this was working but it's not working now so maybe I remember wrong. Anyway, there is an issue with the browser on mac and windows as well as in firefox iPad after adding AG to the home screen, where it's not adapting the grid horizontally but making weird things (grid.beta only, public version works). Pretty sure it was working last week, I didn't notice any issue. For settings on element level I'll answer once I can test properly again.
Okay, yes, it makes sense, but it needs to be made clear to the user. Any setting that is positioned as main, without additional remarks (like the |
So what are my options then to make the predict element font size the same as the keyboard letters and any surrounding buttons with text (like the just an element in the screenshot)? |
…ixel font size for text measuring (Firefox)
Currently the only way is to make the predict element the same size as the other elements. I can also change the calculation of the font-size to only take the height of the element into account, this would cause the predict elements to have the same font size as the other text-only elements in your example (if auto keyboard letter sizing is disabled). However, the reason that I take width and height into account is this - width and height left, only height right: for small portrait-oriented screens it looks ugly if only taking the height into account, because the height is very big, which results in a quite big base font size, which then is adapted individually for each element. Of course we could also add another option to let people choose between these modes, but I wouldn't do it, I think we already have enough options ;) What do you think should be the final solution? @arasaac-dga - what do you think? |
…e lines in order to prevent words disappearing (because width is not perfectly used for multiple lines)
Good morning. We are sorry but we have lost the "thread" on this issue. We cannot follow all the comments on this issue because we are very busy. For our part, we do not see the need to include more options. As you know, we are in favor of simplicity and usability. In the case of predictive text, we see that it is enough for it to have the same font size as the text-only elements, taking into account that these elements only need one line unlike text-only cells that can have more than one. We have many options and adding new ones will make their management much more complex for many of our users. We do see the need to fix the text display issues we reported (which are cut off at the top or bottom depending on their position) in certain configurations (e.g. when the font size is reduced below 5%) or when the global board is used and it is integrated with the normal boards or, of course, when mobile screens are used (in portrait and landscape in some cases),.... If these issues persist, we see that perhaps the appearance of the text being synchronized between devices would not be the best because there is no uniform behavior between devices. |
I cannot reproduce this issue, I've tested it on Windows / Chrome + Firefox, Android / Chrome and iPad / Safari. For me all works fine. So maybe it's already fixed?!
it now shows
I understand. I could try show the demo element in the same size it's shown in the actual grid (even after adding the global grid). But this would be a new issue. So please create a new issue for it and tell me if we should keep it as it is now or remove the demo element for now.
Now changing the element-level background color automatically sets the color category to
but I think this would need some more changes. Now nearly everything in tab
I've now renamed and re-arranged the settings like this: I hope it's clearer that way.
It's controlling this font size in the collect element if both text and images are collected (factor If you want to change something there - please a new issue ;) I've now also changed/fixed these things:
|
The problem seems to be only on Microsoft Edge. In Chrome and Firefox reduce text size without hidde it.
ok. Perfect
Leave it as is now and if we see that suppose a real problem, we will add a new issue to take one of the decisions you propose. At the momment, forget it. We don't think that many people change font size with long-texts.
Yes. Perfect. Perhaps it would be possible to remember the category selection before changing the background or border color, ideally if you reset the custom background color (by clicking Clear), the previous category would be selected again. But the system does not remember the previous selection, forget it.
Our point of view is that if something has to be renamed, it should be the current drop-down menu, which is now called "Advanced options" and renamed to "Appearance options", removing the two options that are not appearance-related. The other two possibilities raised are not liked at all. The Image tab has enough importance and should not be modified. The general tab, in order to maintain coherence with the general configuration of the communicator, should continue to be called General, since it also includes "label" and the options to hide cell and to accumulate or not in the sentence, which are not appearance-related. Thus, we do not see in any case that the General tab should be renamed to Appearance because elements such as label are not appearance-related. All other things ok. |
Despite the tons of various comments/sub-issues you have managed to adress all, as far as I see :)
Yes, I don't think that boards that are created for landscape will in general be used in portrait mode. People who want boards in portrait mode will create boards that fit specifically for portrait mode (so, less columns and more rows). I also don't think that it needs to be an additional setting option, so perfect now.
So, my main point is - and this is not specific to these font/border/color settings but in general - that the settings should have the same structure across all levels (settings for the
Yes, now it's clear :) Small suggestion: Put
Looks good and it also erases my request for having
That's fine but I'd add some remark there like And also yes to the rest (NaN etc.) :) Except for #470 I haven't found any other technical issues across operating systems so far. |
@ms-mialingvo thanks for testing!
I agree with all of what you've said, but would still like to keep it as-is for now, since I want to come to an end for the upcoming release. But if at some point we add more element-level appearance settings, I can move all things to an appearance tab.
Ok, I've done it 👍
actually it's a bug and I wouldn't explicitely describe it as non-bug 😄 I would wait until someone opens an issue for it, so then I see that it's actually something that needs to work. |
In my case is Edge over W10 and after the last update the problem persists
If we want to maintain uniformity, the only option that we think we remember being discarded at the time is to add a new Appearance tab but without eliminating the General tab and, of course, the Image tab, which are important at the element level. In no case do we see that the Image tab should be touched or joined with others and the General tab allows us to accommodate the text label and the other additional options of hiding a cell or adding or not to the accumulated phrase (or future ones that may arise). In any case, in view of this launch and for convenience for Benjamin we continue to think that it is fine with the "Advanced options" accordion and at most renamed to "Appearance options". Afterwards, the unification with the board editing can be undertaken but that would only happen by adding a new appearance tab without touching the others. |
Yeah, that was what I was suggesting/intending originally. |
Anyway, we agree with Benjamin to delay it until there are more options and when grid edit or other pages like manage grid are redesigned. At the momment is ok in Advanced Options. |
strange. If it appears also for other uses, please open a new issue. released with https://github.com/asterics/AsTeRICS-Grid/releases/tag/release-2025-01-27-08.34%2F%2B0100 |
The idea is to add the following cell text customisation options next to the current "Convert element labels" option to "Element labels":
The text was updated successfully, but these errors were encountered: