-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new features #7
Comments
Hi!, well yeah is a mess xD. I was using Notepad++ because its a ligth text editor with some programing tools, but is not a IDE. |
muy bien 😄
ok, if i am not wrong you are using an old computer so maybe VSCode would be too heavy, I will adjust the formattation and push the code, then you could try to follow the existing formattation so you won't need to install more stuff
Exactly, you perfectly got what i was thinking about!
from this |
ok with commit 82bbeac the formatting is all the same in all the sketches! you can download the new branch We can split the todo list and do one at the time to avoid merge conflicts. I can work on this:
could you please rewrite some comments in english and choose better names for the |
Ok, I will do that! |
Yes, github has me a little confused. I know it is an important tool, however I do not know how to use it yet. I did not know how to update my fork when you made the commits, and now that I did commit it does not let me update it. I think I will erase my fork and I will clone it directly from yours I will try to update correctly from now on. |
ningùn problema! git is quite complex 😫 So could you please confirm me that this is what you did?
I need to know this because otherwise i need to look for missing commits |
Yeah I do that! the noob way xD |
normal man! i did it that way until the last month! so after you deleted your remote repo and your working folder do something like this: this change the branch and to update your remote from your local do then do a PR from github! try to to it and add somethin (like a new line) in some file and do a PR! then to update your remote repo from my remote repo you should be able to do all from github web and then there is also a more complex method which doiesn't need github web: |
Hi and thanks, I was able to synchronize the fork! |
@sancho11 first of all thanks for the changes! it was very good to use small function to draw the channels, this is the correct approach 😎 I started making small changes after lunch, i stopped only now, damned programming 😂
The channel selection part is not working, i am not sure where the error is, the only part i think that i changed was this anyway do i remember wrong or once the reducer was changed with the mouse wheel instead of the mouse buttons? still there is more work to be done especially to make the code more readable, i have difficulties to understand some functions 😂 I think that next time i will rework the pin assignment to make it smaller! ahhh be careful this time to bring this changes to your repository, check that your pr branch is even with this! right now you should see `This branch is 2 commits behind aster94:pr' |
"anyway do i remember wrong or once the reducer was changed with the mouse wheel instead of the mouse buttons?" Im glad that you like the changes! |
okkkkkk don't worry for now we can leave these changes and think more about them later |
The drawbacks were solved, for this I had to make minimal changes in some sections of the code. |
#9 merged! great work sancho 😁 |
Unfortunately for other duties coming I won't be able to complete the work on this 😥 |
It's a shame. I hope you do well in what you are doing! I'm also busy but as soon as I can, I'll make more contributions to the project. Take it easy and good luck! |
thanks sancho! unfortunately I have the italian version of the "MIR examen" so until the summer i would be completely focused on it! |
I'm not from Spain (I'm from Latin America), I had to google it, haha. |
thanks Sancho, I will write back 😃 |
Best of luck aster94, hope you do well! To all, I've got some time to work on moving the documentation from computer_interface.pde to the readme. I've forked the repo and am keeping up to date with the development branch. I'll submit any PR's from there. |
@sancho11
We need to decide which formattation of the code we will keep because it is becoming a mess of whitespaces, wrong indentation ecc. Which IDE are you using for processing and which one for arduino?
I am using vscode for arduino and the default formatting and for processing the default IDE but the default formatting is not very good, maybe is better to use all on vscode this way the formatting between arduino and processing will be the same
I also made a todo list
pinMode
anddigitalWrite
outside time-critical task. This will improve readability and won't change the efficencyreducer
LED_BUILTIN
for readability and easier port to new boardsWhat do you think about?
I can work on the communication of the samples number between processing and arduino
The text was updated successfully, but these errors were encountered: