Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org-babel-execute-src-block added one more argument #92

Open
dalgong opened this issue Dec 9, 2022 · 0 comments · May be fixed by #93
Open

org-babel-execute-src-block added one more argument #92

dalgong opened this issue Dec 9, 2022 · 0 comments · May be fixed by #93

Comments

@dalgong
Copy link

dalgong commented Dec 9, 2022

ob-async-org-babel-execute-src-block has the following signature.

(defun ob-async-org-babel-execute-src-block (&optional orig-fun arg info params)
 ...)

However, new version of org changed its signature as follows:

(defun org-babel-execute-src-block (&optional arg info params executor-type)
 ...)

We should add extra argument to not trigger errors.
stsquad added a commit to stsquad/ob-async that referenced this issue Dec 20, 2022
@stsquad
ob-async: update function signature of ob-async-org-babel-execute-src…
4970462 
…-block

Since 0625651e (Update to Org 9.6-3-ga4d38e) ob-async has been broken
on the emacs-29 branch. Fix this by expanding the function to include
the extra parameters.

This works but I'm unsure what effect it will have on older emacsen.

Fixes: astahlman#92
Signed-off-by: Alex Bennée <[email protected]>
@stsquad stsquad linked a pull request Dec 20, 2022 that will close this issue
Open
stsquad added a commit to stsquad/ob-async that referenced this issue Dec 21, 2022
@stsquad
ob-async: update function signature of ob-async-org-babel-execute-src…
08d465f 
…-block

Since 0625651e (Update to Org 9.6-3-ga4d38e) ob-async has been broken
on the emacs-29 branch. Fix this by expanding the function to include
the extra parameters.

This works but I'm unsure what effect it will have on older emacsen.

Fixes: astahlman#92
Signed-off-by: Alex Bennée <[email protected]>

---
v2
  - use &rest for the new arg
  - use apply to call the original function
stsquad added a commit to stsquad/ob-async that referenced this issue Dec 21, 2022
@stsquad
ob-async: update function signature of ob-async-org-babel-execute-src…
5ec7d34 
…-block

Since 0625651e (Update to Org 9.6-3-ga4d38e) ob-async has been broken
on the emacs-29 branch. Fix this by expanding the function to include
&rest other-args and future proofing against org-mode adding new
arguments that ob-async doesn't need to see.

Fixes: astahlman#92
Signed-off-by: Alex Bennée <[email protected]>

---
v2
  - use &rest for the new arg
  - use apply to call the original function
v3
  - use other-args
farynaio added a commit to farynaio/ob-async that referenced this issue Aug 3, 2023
@farynaio
Fixes: astahlman#92
e7e755f 
stsquad@4970462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ob-async: update function signature of ob-async-org-babel-execute-src… stsquad/ob-async
1 participant
@dalgong