Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable runkit7 for the PHP 7.0 unit tests #21

Open
stevegrunwell opened this issue Nov 24, 2020 · 0 comments
Open

Enable runkit7 for the PHP 7.0 unit tests #21

stevegrunwell opened this issue Nov 24, 2020 · 0 comments
Labels
code quality Improve the quality of the codebase

Comments

@stevegrunwell
Copy link
Member

Runkit7 dropped PHP 7.0 support in version 2.0.0, but releases < 2.0.2 are not available via PECL.

As a result, there isn't an easy way to instruct GitHub Actions to install runkit7-1.0.11 (the last of the 1.x branch) for the PHP 7.0 test. I also had a heck of a time getting this working over on stevegrunwell/runkit7-installer.

#20 broke the PHP 5.6–7.1 setups into separate steps, but 7.0 will currently fail to install runkit7 (meaning those tests will simply be skipped).

Eventually, it'd be nice to get this working for the sake of completion, but it's not worth holding the 0.2.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improve the quality of the codebase
Projects
None yet
Development

No branches or pull requests

1 participant