Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): support pnpm v9.7+ patches without version specifier #2059

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(npm): support pnpm v9.7+ patches without version specifier #2059

wants to merge 1 commit into from

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jan 7, 2025

Fix #2031

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

PNPM v9.7+ supports pnpm.patchedDependencies specifiers with no version specified.

Test plan

  • New test cases added

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Jan 7, 2025 •
edited
Loading

Test

All tests were cache hits

212 tests (100.0%) were fully cached saving 38s.

Test

e2e/bzlmod

Buildkite build #6980 is running...

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 138ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 6s.

Test

e2e/npm_link_package

All tests were cache hits

3 tests (100.0%) were fully cached saving 555ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

3 tests (100.0%) were fully cached saving 575ms.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 26ms.

Test

e2e/npm_translate_lock_multi

Buildkite build #6980 is running...

Test

e2e/npm_translate_lock_partial_clone

Waiting for runner...

Test

e2e/npm_translate_lock_replace_packages

All tests were cache hits

3 tests (100.0%) were fully cached saving 317ms.

Test

e2e/npm_translate_lock_subdir_patch

Buildkite build #6980 is running...

Test

e2e/npm_translate_package_lock

Waiting for runner...

Test

e2e/npm_translate_yarn_lock

Waiting for runner...

Test

e2e/package_json_module

Buildkite build #6980 is running...

Test

e2e/pnpm_lockfiles

Waiting for runner...

Test

e2e/pnpm_workspace

Waiting for runner...

Test

e2e/pnpm_workspace_rerooted

Waiting for runner...

Test

e2e/repo_mapping

Waiting for runner...

Test

e2e/rules_foo

Waiting for runner...

Test

e2e/runfiles

Waiting for runner...

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 181ms.

Buildifier      Format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle Awaiting requested review from alexeagle

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

@dzbarsky dzbarsky Awaiting requested review from dzbarsky

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Rules JS misses version-less patches that pnpm itself can apply
1 participant
@jbedard